From: William Lee Irwin III <wli@holomorphy.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
"Randy.Dunlap" <rddunlap@osdl.org>, Jens Axboe <axboe@suse.de>,
James Bottomley <James.Bottomley@SteelEye.com>
Subject: Re: news about IDE PIO HIGHMEM bug
Date: Wed, 27 Oct 2004 11:48:36 -0700 [thread overview]
Message-ID: <20041027184836.GA12934@holomorphy.com> (raw)
In-Reply-To: <417FEA09.6080502@pobox.com>
Christoph Hellwig wrote:
>> I think this is the wrong level of interface exposed. Just add two hepler
>> kmap_atomic_sg/kunmap_atomic_sg that gurantee to map/unmap a sg list entry,
>> even if it's bigger than a page.
On Wed, Oct 27, 2004 at 02:33:45PM -0400, Jeff Garzik wrote:
> Why bother mapping anything larger than a page, when none of the users
> need it?
> P.S. In your scheme you would need four helpers; you forgot kmap_sg()
> and kunmap_sg().
This is all a non-issue. The page structure just represents little more
than a physical address to the block layer in the context of merging,
so the pfn_to_page(page_to_pfn(...) + ...) bits calculate this properly.
There is just nothing interesting going on here. Generate the page
structure for the piece of the segment, kmap_atomic() it, and it's done.
-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-10-27 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <58cb370e041027074676750027@mail.gmail.com>
2004-10-27 15:14 ` news about IDE PIO HIGHMEM bug (was: Re: 2.6.9-mm1) Jeff Garzik
2004-10-27 15:52 ` Martin J. Bligh
2004-10-27 15:59 ` Jeff Garzik
2004-10-27 17:36 ` Martin J. Bligh
2004-10-27 16:01 ` Martin J. Bligh
2004-10-27 16:35 ` [PATCH] " Jeff Garzik
2004-10-27 21:29 ` Andrew Morton
2004-10-27 21:31 ` Jeff Garzik
2004-10-27 21:34 ` William Lee Irwin III
2004-10-27 18:08 ` Christoph Hellwig
2004-10-27 18:33 ` news about IDE PIO HIGHMEM bug Jeff Garzik
2004-10-27 18:48 ` William Lee Irwin III [this message]
2004-10-28 0:18 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041027184836.GA12934@holomorphy.com \
--to=wli@holomorphy.com \
--cc=James.Bottomley@SteelEye.com \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox