From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 14 Oct 2004 20:29:26 +0100 From: Matthew Wilcox Subject: Re: [RESEND][PATCH 4/6] Add page becoming writable notification Message-ID: <20041014192926.GT16153@parcelfarce.linux.theplanet.co.uk> References: <24449.1097780701@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24449.1097780701@redhat.com> Sender: owner-linux-mm@kvack.org Return-Path: To: David Howells Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org List-ID: On Thu, Oct 14, 2004 at 08:05:01PM +0100, David Howells wrote: > +static inline int do_wp_page_mk_pte_writable(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long address, > + pte_t *page_table, > + struct page *old_page, > + pte_t pte) I protest. There are at least 3 vowels and 2 non-acronyms in this function name. Also, 6 arguments is clearly too few. Can we not also pass a struct urb, an ethtool_wolinfo and a Scsi_Cmnd? -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org