* Update page-flags.h commentary
@ 2004-09-20 19:35 Marcelo Tosatti
2004-09-20 21:41 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Marcelo Tosatti @ 2004-09-20 19:35 UTC (permalink / raw)
To: linux-mm, akpm
Andrew,
There is no such thing as "page->age" (this was true sometime back in the past).
Update page-flags to reflect it.
--- linux-2.6.9-rc1-mm5/include/linux/page-flags.h.orig 2004-09-20 18:04:51.871654024 -0300
+++ linux-2.6.9-rc1-mm5/include/linux/page-flags.h 2004-09-20 18:05:19.647431464 -0300
@@ -27,8 +27,8 @@
* For choosing which pages to swap out, inode pages carry a PG_referenced bit,
* which is set any time the system accesses that page through the (mapping,
* index) hash table. This referenced bit, together with the referenced bit
- * in the page tables, is used to manipulate page->age and move the page across
- * the active, inactive_dirty and inactive_clean lists.
+ * in the page tables, is used to move the page across the active,
+ * inactive_dirty and inactive_clean lists.
*
* Note that the referenced bit, the page->lru list_head and the active,
* inactive_dirty and inactive_clean lists are protected by the
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Update page-flags.h commentary\
2004-09-20 21:41 ` Christoph Hellwig
@ 2004-09-20 20:30 ` Marcelo Tosatti
0 siblings, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2004-09-20 20:30 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-mm, akpm
On Mon, Sep 20, 2004 at 10:41:12PM +0100, Christoph Hellwig wrote:
> On Mon, Sep 20, 2004 at 04:35:32PM -0300, Marcelo Tosatti wrote:
> > Andrew,
> >
> > There is no such thing as "page->age" (this was true sometime back in the past).
> >
> > Update page-flags to reflect it.
> >
> >
> > --- linux-2.6.9-rc1-mm5/include/linux/page-flags.h.orig 2004-09-20 18:04:51.871654024 -0300
> > +++ linux-2.6.9-rc1-mm5/include/linux/page-flags.h 2004-09-20 18:05:19.647431464 -0300
> > @@ -27,8 +27,8 @@
> > * For choosing which pages to swap out, inode pages carry a PG_referenced bit,
> > * which is set any time the system accesses that page through the (mapping,
> > * index) hash table. This referenced bit, together with the referenced bit
> > - * in the page tables, is used to manipulate page->age and move the page across
> > - * the active, inactive_dirty and inactive_clean lists.
> > + * in the page tables, is used to move the page across the active,
> > + * inactive_dirty and inactive_clean lists.
>
> there's also no inactive_dirty or inactive_clean lists anymore. Or an
> mapping, index hashtable..
True! Andrew, ignore my patch.
If no one prepares a patch I'll do so later on.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Update page-flags.h commentary
2004-09-20 19:35 Update page-flags.h commentary Marcelo Tosatti
@ 2004-09-20 21:41 ` Christoph Hellwig
2004-09-20 20:30 ` Update page-flags.h commentary\ Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2004-09-20 21:41 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-mm, akpm
On Mon, Sep 20, 2004 at 04:35:32PM -0300, Marcelo Tosatti wrote:
> Andrew,
>
> There is no such thing as "page->age" (this was true sometime back in the past).
>
> Update page-flags to reflect it.
>
>
> --- linux-2.6.9-rc1-mm5/include/linux/page-flags.h.orig 2004-09-20 18:04:51.871654024 -0300
> +++ linux-2.6.9-rc1-mm5/include/linux/page-flags.h 2004-09-20 18:05:19.647431464 -0300
> @@ -27,8 +27,8 @@
> * For choosing which pages to swap out, inode pages carry a PG_referenced bit,
> * which is set any time the system accesses that page through the (mapping,
> * index) hash table. This referenced bit, together with the referenced bit
> - * in the page tables, is used to manipulate page->age and move the page across
> - * the active, inactive_dirty and inactive_clean lists.
> + * in the page tables, is used to move the page across the active,
> + * inactive_dirty and inactive_clean lists.
there's also no inactive_dirty or inactive_clean lists anymore. Or an
mapping, index hashtable..
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-20 21:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-20 19:35 Update page-flags.h commentary Marcelo Tosatti
2004-09-20 21:41 ` Christoph Hellwig
2004-09-20 20:30 ` Update page-flags.h commentary\ Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox