linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: akpm@osdl.org
Cc: linux-mm@kvack.org
Subject: use for page_state accounting fields
Date: Mon, 16 Aug 2004 16:29:42 -0300	[thread overview]
Message-ID: <20040816192941.GB21238@logos.cnet> (raw)

Hi Andrew,

I suppose you wrote the page_state per-CPU statistics structure.

There are some fields, for instance pgactivate/pgdeactivate, that
do not seem to be used anywhere. Sure, they are useful for statistics, 
but no place in the kernel exports them to userspace AFAICS.

        unsigned long pgactivate;       /* pages moved inactive->active */
        unsigned long pgdeactivate;     /* pages moved active->inactive */

Counting them is somewhat expensive I believe (need to disable IRQ), based
on the assumption that these days any cycle is a loss.

So, from my POV we should 

a) export them to userspace
b) surround them by CONFIG_DEBUG_MMSTATS or something similar

Tell me I'm wrong.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

             reply	other threads:[~2004-08-16 19:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-16 19:29 Marcelo Tosatti [this message]
2004-08-16 21:31 ` Andrew Morton
2004-08-16 20:33   ` Marcelo Tosatti
2004-08-16 22:34     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040816192941.GB21238@logos.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=akpm@osdl.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox