linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* use for page_state accounting fields
@ 2004-08-16 19:29 Marcelo Tosatti
  2004-08-16 21:31 ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: Marcelo Tosatti @ 2004-08-16 19:29 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm

Hi Andrew,

I suppose you wrote the page_state per-CPU statistics structure.

There are some fields, for instance pgactivate/pgdeactivate, that
do not seem to be used anywhere. Sure, they are useful for statistics, 
but no place in the kernel exports them to userspace AFAICS.

        unsigned long pgactivate;       /* pages moved inactive->active */
        unsigned long pgdeactivate;     /* pages moved active->inactive */

Counting them is somewhat expensive I believe (need to disable IRQ), based
on the assumption that these days any cycle is a loss.

So, from my POV we should 

a) export them to userspace
b) surround them by CONFIG_DEBUG_MMSTATS or something similar

Tell me I'm wrong.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-08-16 22:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-16 19:29 use for page_state accounting fields Marcelo Tosatti
2004-08-16 21:31 ` Andrew Morton
2004-08-16 20:33   ` Marcelo Tosatti
2004-08-16 22:34     ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox