From: Dimitri Sivanich <sivanich@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: manfred@colorfullife.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, lse-tech@lists.sourceforge.net
Subject: Re: [PATCH] Locking optimization for cache_reap
Date: Mon, 26 Jul 2004 21:01:34 -0500 [thread overview]
Message-ID: <20040727020134.GA23967@sgi.com> (raw)
In-Reply-To: <20040727014757.GA23937@sgi.com>
On Mon, Jul 26, 2004 at 08:47:57PM -0500, Dimitri Sivanich wrote:
>
> While you've got irq's disabled, drain_array() (the function my patch removes)
> acquires the cache spin_lock, then releases it. Cache_reap then acquires
> it again (with irq's having been off the entire time). My testing has found
> that simply acquiring the lock once while irq's are off results in fewer
> excessively long latencies.
>
> Results probably vary somewhat depending on the circumstance.
Of course, I should add that all of this is from the perspective of the
cpu doing the cache_reap. If others feel that this may add too much
latency to other paths, other solutions may be in order.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2004-07-27 2:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-23 19:05 Dimitri Sivanich
2004-07-27 1:01 ` Andrew Morton
2004-07-27 1:47 ` Dimitri Sivanich
2004-07-27 1:59 ` Aroop MP
[not found] ` <20040727020338.GB23967@sgi.com>
2004-07-27 2:11 ` lsattr: Inappropriate ioctl for device While reading flags!!! Aroop MP
2004-07-27 6:40 ` Philippe Troin
2004-07-27 2:01 ` Dimitri Sivanich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040727020134.GA23967@sgi.com \
--to=sivanich@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox