From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: lost dirty bits.
Date: Wed, 16 Jun 2004 08:12:14 +0100 [thread overview]
Message-ID: <20040616071214.GA7810@infradead.org> (raw)
In-Reply-To: <20040615210919.1c82a5c8.akpm@osdl.org>
On Tue, Jun 15, 2004 at 09:09:19PM -0700, Andrew Morton wrote:
> #define ClearPageReferenced(page) clear_bit(PG_referenced, &(page)->flags)
> #define TestClearPageReferenced(page) test_and_clear_bit(PG_referenced, &(page)->flags)
>
> -#ifndef arch_set_page_uptodate
> -#define arch_set_page_uptodate(page) do { } while (0)
> +#ifdef arch_set_page_uptodate
> +#define SetPageUptodate(page) arch_set_page_uptodate(page)
> +#else
> +#define SetPageUptodate(page) set_bit(PG_uptodate, &(page)->flags)
> #endif
Eek. It looks like SetPageUptodate, it smells like SetPageUptodate, why
do you give it another name? Just put a
#ifndef SetPageUptodate /* S390 wants to override this */
#define SetPageUptodate set_bit(PG_uptodate, &(page)->flags)
#endif
in mm.h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-06-16 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-15 17:44 Martin Schwidefsky
2004-06-16 4:09 ` Andrew Morton
2004-06-16 7:12 ` Christoph Hellwig [this message]
2004-06-16 8:42 Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040616071214.GA7810@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox