From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 26 Mar 2004 08:53:43 +0100 From: Andrea Arcangeli Subject: Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix Message-ID: <20040326075343.GB12484@dualathlon.random> References: <20040325225919.GL20019@dualathlon.random> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Rajesh Venkatasubramanian Cc: akpm@osdl.org, torvalds@osdl.org, hugh@veritas.com, mbligh@aracnet.com, riel@redhat.com, mingo@elte.hu, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Thu, Mar 25, 2004 at 11:06:50PM -0500, Rajesh Venkatasubramanian wrote: > > Hi Andrea, > > I am yet to look at the new -aa you released. A small change is > required below. Currently, I cannot generate a patch. Sorry. Please > fix it by hand. Thanks. > > > > > - list_for_each_entry(vma, list, shared) { > > + vma = __vma_prio_tree_first(root, &iter, h_pgoff, h_pgoff); > > This should be: > vma = __vma_prio_tree_first(root, &iter, h_pgoff, ULONG_MAX); > > > + while (vma) { > > unsigned long h_vm_pgoff; > [snip] > > + vma = __vma_prio_tree_next(vma, root, &iter, h_pgoff, h_pgoff); > > } > > and here it should be: > vma = __vma_prio_tree_next(vma, root, &iter, > h_pgoff, ULONG_MAX); I was missing all vmas with vm_start starting after h_pgoff. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org