From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Phillips Subject: Re: [RFC] Distributed mmap API Date: Wed, 25 Feb 2004 17:07:05 -0500 References: <20040216190927.GA2969@us.ibm.com> <200402251604.19040.phillips@arcor.de> <20040225140727.0cde826e.akpm@osdl.org> In-Reply-To: <20040225140727.0cde826e.akpm@osdl.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200402251707.05932.phillips@arcor.de> Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: paulmck@us.ibm.com, sct@redhat.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Wednesday 25 February 2004 17:07, Andrew Morton wrote: > Daniel Phillips wrote: > > - pte = ptep_get_and_clear(ptep); > > + if (unlikely(!all) && is_anon(pfn_to_page(pfn))) > > + continue; > > + pte = ptep_get_and_clear(ptep); /* get dirty bit atomically */ > > tlb_remove_tlb_entry(tlb, ptep, address+offset); > > if (pfn_valid(pfn)) { > > I think you need to check pfn_valid() before running is_anon(pfn_to_page()) Easy enough: if (unlikely(!all) && pfn_valid(pfn) && is_anon(pfn_to_page(pfn))) but how can we legitimately get !pfn_valid there? Regards, Daniel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org