From: "Krishnakumar. R" <krishnakumar@naturesoft.net>
To: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.6.3-rc3-mm1
Date: Mon, 16 Feb 2004 17:09:58 +0530 [thread overview]
Message-ID: <200402161709.58555.krishnakumar@naturesoft.net> (raw)
In-Reply-To: <20040216015823.2dafabb4.akpm@osdl.org>
Hi,
The patch given below removes the following errors
while compiling:
-------------------------------------------------------------------------------
fs/ext3/super.c: In function `ext3_quota_on':
fs/ext3/super.c:2229: warning: ISO C90 forbids mixed declarations and code
fs/ext3/super.c:2234: error: initializer element is not constant
fs/ext3/super.c:2234: error: (near initialization for `ext3_fs_type.get_sb')
fs/ext3/super.c:2268: error: initializer element is not constant
fs/ext3/super.c:2268: warning: ISO C90 forbids mixed declarations and code
fs/ext3/super.c:2269: error: initializer element is not constant
fs/ext3/super.c:2269: error: syntax error at end of input
make[2]: *** [fs/ext3/super.o] Error 1
make[1]: *** [fs/ext3] Error 2
make: *** [fs] Error 2
--------------------------------------------------------------------------------
The patch is just compilation tested.
Hence not sure whether its the right fix.
I derived at the patch by looking at the indentation
of the code.
Regards,
KK.
Diffstat output:
super.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
The patch:
--- linux-2.6.3-rc3-mm1/fs/ext3/super.orig.c 2004-02-16 16:41:52.089749760
+0530
+++ linux-2.6.3-rc3-mm1/fs/ext3/super.c 2004-02-16 16:53:12.432321968 +0530
@@ -2209,7 +2209,7 @@
return err;
if (nd.mnt->mnt_sb != sb) /* Quotafile not on the same fs? */
return -EXDEV;
- if (nd.dentry->d_parent->d_inode != sb->s_root->d_inode) {
+ if (nd.dentry->d_parent->d_inode != sb->s_root->d_inode)
/* Quotafile not of fs root? */
printk(KERN_WARNING "EXT3-fs: Quota file not on filesystem "
"root. Journalled quota will not work\n");
--
HomePage: http://puggy.symonds.net/~krishnakumar
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-02-16 11:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 9:58 2.6.3-rc3-mm1 Andrew Morton
2004-02-16 11:39 ` Krishnakumar. R [this message]
2004-02-16 12:16 ` 2.6.3-rc3-mm1 Bill Davidsen
2004-02-16 17:54 ` 2.6.3-rc3-mm1 Andrew Morton
2004-02-16 19:19 ` 2.6.3-rc3-mm1 Bill Davidsen
2004-02-16 21:12 ` 2.6.3-rc3-mm1 Zwane Mwaikambo
2004-02-16 21:29 ` 2.6.3-rc3-mm1 Andrew Morton
2004-02-17 21:26 ` 2.6.3-rc3-mm1 Zwane Mwaikambo
2004-02-16 19:23 ` 2.6.3-rc3-mm1 (compile stats) John Cherry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402161709.58555.krishnakumar@naturesoft.net \
--to=krishnakumar@naturesoft.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox