From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Eugene Teo <eugene.teo@eugeneteo.net>
Cc: linux-mm@kvack.org, kernel-janitors@osdl.org
Subject: Re: [Kernel-janitors] [PATCH] Check return code in mm/vmscan.c
Date: Mon, 16 Feb 2004 14:36:42 -0800 [thread overview]
Message-ID: <20040216143642.48b2c176.rddunlap@osdl.org> (raw)
In-Reply-To: <20040104051125.GF20458@eugeneteo.net>
On Sun, 4 Jan 2004 13:11:26 +0800 Eugene Teo <eugene.teo@eugeneteo.net> wrote:
| <quote sender="Matthew Wilcox">
| > On Sat, Jan 03, 2004 at 09:25:24PM +0800, Eugene Teo wrote:
| > > http://www.anomalistic.org/patches/vmscan-check-ret-kernel_thread-fix-2.6.1-rc1-mm1.patch
| > >
| > > diff -Naur -X /home/amnesia/w/dontdiff 2.6.1-rc1-mm1/mm/vmscan.c 2.6.1-rc1-mm1-fix/mm/vmscan.c
| > > --- 2.6.1-rc1-mm1/mm/vmscan.c 2004-01-03 20:33:39.000000000 +0800
| > > +++ 2.6.1-rc1-mm1-fix/mm/vmscan.c 2004-01-03 21:16:30.000000000 +0800
| > > @@ -1093,10 +1093,16 @@
| > >
| > > static int __init kswapd_init(void)
| > > {
| > > + int ret;
| > > pg_data_t *pgdat;
| > > swap_setup();
| > > - for_each_pgdat(pgdat)
| > > - kernel_thread(kswapd, pgdat, CLONE_KERNEL);
| > > + for_each_pgdat(pgdat) {
| > > + ret = kernel_thread(kswapd, pgdat, CLONE_KERNEL);
| > > + if (ret < 0) {
| > > + printk("%s: unable to start kernel thread\n", __FUNCTION__);
| > > + return ret;
| > > + }
| > > + }
| > > total_memory = nr_free_pagecache_pages();
| > > return 0;
| > > }
| >
| > If your new code is triggered, we've just failed to set up total_memory.
| > I expect the system to behave very oddly after this ;-)
|
| a panic call seems to be more appropriate :)
|
| Here is the new fix. Patch compiles, and tested.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Eugene, patch is tested how? What do you mean by "tested"?
In what conditions?
| http://www.anomalistic.org/patches/vmscan-check-ret-kernel_thread-fix-2.6.1-rc1-mm1.patch
|
| diff -Naur -X /home/amnesia/w/dontdiff 2.6.1-rc1-mm1/mm/vmscan.c 2.6.1-rc1-mm1-fix/mm/vmscan.c
| --- 2.6.1-rc1-mm1/mm/vmscan.c 2004-01-04 10:29:24.000000000 +0800
| +++ 2.6.1-rc1-mm1-fix/mm/vmscan.c 2004-01-04 13:04:52.000000000 +0800
| @@ -1093,10 +1093,14 @@
|
| static int __init kswapd_init(void)
| {
| + int ret;
| pg_data_t *pgdat;
| swap_setup();
| - for_each_pgdat(pgdat)
| - kernel_thread(kswapd, pgdat, CLONE_KERNEL);
| + for_each_pgdat(pgdat) {
| + ret = kernel_thread(kswapd, pgdat, CLONE_KERNEL);
| + if (ret < 0)
| + panic("%s: unable to initialise kswapd\n", __FUNCTION__);
| + }
| total_memory = nr_free_pagecache_pages();
| return 0;
| }
|
--
~Randy
kernel-janitors project: http://janitor.kernelnewbies.org/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2004-02-16 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040103132524.GA21909@eugeneteo.net>
2004-01-03 22:27 ` Matthew Wilcox
2004-01-04 5:11 ` Eugene Teo
2004-02-16 22:36 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040216143642.48b2c176.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=eugene.teo@eugeneteo.net \
--cc=kernel-janitors@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox