From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] skip offline CPUs in show_free_areas
Date: Tue, 10 Feb 2004 08:22:35 -0800 [thread overview]
Message-ID: <20040210082235.3ccf817d.akpm@osdl.org> (raw)
In-Reply-To: <20040210132301.GA11045@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
>
> Without this ouput on a box with 8cpus and NR_CPUS=64 looks rather
> strange.
>
>
> Index: mm/page_alloc.c
> ===================================================================
> RCS file: /home/cvs/linux/mm/page_alloc.c,v
> retrieving revision 1.113
> diff -u -p -r1.113 page_alloc.c
> --- mm/page_alloc.c 10 Jan 2004 04:59:57 -0000 1.113
> +++ mm/page_alloc.c 10 Feb 2004 13:17:43 -0000
> @@ -972,7 +972,13 @@ void show_free_areas(void)
> printk("\n");
>
> for (cpu = 0; cpu < NR_CPUS; ++cpu) {
> - struct per_cpu_pageset *pageset = zone->pageset + cpu;
> + struct per_cpu_pageset *pageset;
> +
> + if (!cpu_online(cpu))
> + continue;
Thanks. I think I'll change that to cpu_possible(). Because there might
still be pages there from the time when that cpu used to be online.
Otherwise we wouldn't notice leaks due to cpu downing.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2004-02-10 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 13:23 Christoph Hellwig
2004-02-10 13:41 ` Nick Piggin
2004-02-10 16:22 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040210082235.3ccf817d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox