linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ben Collins <bcollins@debian.org>
To: Greg KH <greg@kroah.com>
Cc: Robert Gadsdon <robert@gadsdon.giointernet.co.uk>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.6.2-mm1 aka "Geriatric Wombat"
Date: Sat, 7 Feb 2004 12:27:58 -0500	[thread overview]
Message-ID: <20040207172757.GQ1042@phunnypharm.org> (raw)
In-Reply-To: <20040206182200.GE32116@kroah.com>

On Fri, Feb 06, 2004 at 10:22:00AM -0800, Greg KH wrote:
> On Fri, Feb 06, 2004 at 09:47:30AM -0500, Ben Collins wrote:
> > On Thu, Feb 05, 2004 at 10:26:14AM -0800, Greg KH wrote:
> > > On Thu, Feb 05, 2004 at 01:11:21PM +0000, Robert Gadsdon wrote:
> > > > 2.6.2-mm1 tombstone "Badness in kobject_get....." when booting:
> > > 
> > > Oooh, not nice.  That means a kobject is being used before it has been
> > > initialized.  Glad to see that check finally helps out...
> > 
> > Doesn't sound like a bug in ieee1394. This bus for each is done on the
> > ieee1394_bus_type, which is registered way ahead of time. Nothing is in
> > that device list that didn't come from device_register(). Has something
> > new changed to where I need to prep the device more before passing it to
> > device_register()?
> 
> No, not at all.  You are initializing the structure to 0 before setting
> any fields in it, right?  But that wouldn't be the symptom we are seeing
> here...

Yeah, it's being memset() to zero. After that I set the parent and the
bus_id, and then call device_register().

One thing I notice is that I am not checking the return value of
device_register(), however if that fails, the device shouldn't be in the
device list for the bus, correct?

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
WatchGuard - http://www.watchguard.com/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  parent reply	other threads:[~2004-02-07 17:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.h1qu7q8.n6mopi@ifi.uio.no>
2004-02-05 13:11 ` Robert Gadsdon
2004-02-05 18:26   ` Greg KH
2004-02-05 18:29     ` Ben Collins
2004-02-05 20:14       ` Andrew Morton
2004-02-05 20:29         ` Ben Collins
2004-02-06 14:47     ` Ben Collins
2004-02-06 18:22       ` Greg KH
2004-02-06 18:39         ` Ben Collins
2004-02-07 17:27         ` Ben Collins [this message]
2004-02-07 19:13           ` Greg KH
2004-02-07 23:08             ` Ben Collins
2004-02-05  9:44 Andrew Morton
2004-02-05  9:55 ` Nikita Danilov
2004-02-05 10:00 ` Russell King
2004-02-05 10:37   ` Jeff Garzik
2004-02-05 10:50     ` Russell King
2004-02-05 11:47 ` Nick Piggin
2004-02-05 16:11   ` Martin J. Bligh
2004-02-05 16:16     ` Nick Piggin
2004-02-05 16:20     ` Nikita Danilov
2004-02-05 17:58 ` John Cherry
2004-02-05 19:23 ` Deepak Saxena
2004-02-05 20:05   ` Greg KH
2004-02-06 18:02 ` Thomas Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040207172757.GQ1042@phunnypharm.org \
    --to=bcollins@debian.org \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=robert@gadsdon.giointernet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox