From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Wed, 4 Feb 2004 02:11:53 -0800
From: Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 4/5] mm improvements
Message-Id: <20040204021153.13bb31a1.akpm@osdl.org>
In-Reply-To: <4020BE77.7040303@cyberone.com.au>
References: <4020BDCB.8030707@cyberone.com.au>
	<4020BE77.7040303@cyberone.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-linux-mm@kvack.org
Return-Path: <owner-linux-mm@kvack.org>
To: Nick Piggin <piggin@cyberone.com.au>
Cc: linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>

Nick Piggin <piggin@cyberone.com.au> wrote:
>
> +	if (zone->nr_active >= zone->nr_inactive*4)
>  +		/* ratio will be >= 2 */
>  +		imbalance = 8*nr_pages;
>  +	else if (zone->nr_active >= zone->nr_inactive*2)
>  +		/* 1 < ratio < 2 */
>  +		imbalance = 4*nr_pages*zone->nr_active / (zone->nr_inactive*2);

This can cause a divide-by-zero, yes?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>