From: viro@parcelfarce.linux.theplanet.co.uk
To: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.6.2-rc1-mm1
Date: Thu, 22 Jan 2004 15:19:43 +0000 [thread overview]
Message-ID: <20040122151943.GW21151@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040122110342.A9271@infradead.org>
On Thu, Jan 22, 2004 at 11:03:42AM +0000, Christoph Hellwig wrote:
> > sysfs-class-06-raw.patch
> > From: Greg KH <greg@kroah.com>
> > Subject: [PATCH] add sysfs class support for raw devices [06/10]
>
> This one exports get_gendisk, which is a no-go.
Moreover, it obviously leaks references to struct gendisk _and_ changes
semantics of RAW_SETBIND in incompatible way.
Consider that vetoed. And yes, get_gendisk() issue alone would be enough.
Greg, please, RTFS to see at which point do we decide which driver will
be used by raw device. It's _not_ RAW_SETBIND, it's open(). So where
your symlink should point is undecided until the same point.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-01-22 15:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-22 9:35 2.6.2-rc1-mm1 Andrew Morton
2004-01-22 11:03 ` 2.6.2-rc1-mm1 Christoph Hellwig
2004-01-22 15:19 ` viro [this message]
2004-01-22 20:31 ` 2.6.2-rc1-mm1 Andrew Morton
2004-01-22 21:30 ` 2.6.2-rc1-mm1 Adrian Bunk
2004-01-22 23:38 ` 2.6.2-rc1-mm1 Greg KH
2004-01-23 0:24 ` 2.6.2-rc1-mm1 viro
2004-01-23 0:41 ` 2.6.2-rc1-mm1 Greg KH
2004-01-22 11:05 ` 2.6.2-rc1-mm1 Christoph Hellwig
2004-01-22 11:07 ` 2.6.2-rc1-mm1 Christoph Hellwig
2004-01-22 11:12 ` 2.6.2-rc1-mm1 Christoph Hellwig
2004-01-22 12:17 ` 2.6.2-rc1-mm1 Jeff Dike
2004-01-22 12:00 ` 2.6.2-rc1-mm1 Christoph Hellwig
2004-01-22 13:28 ` 2.6.2-rc1-mm1 Jeff Dike
2004-01-22 16:26 ` 2.6.2-rc1-mm1 (compile stats) John Cherry
2004-01-22 21:12 ` 2.6.2-rc1-mm1 Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040122151943.GW21151@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox