From: Andrew Morton <akpm@osdl.org>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: linux-mm@kvack.org, guillaume@morinfr.org
Subject: Re: [PATCH] Clear dirty bits etc on compound frees
Date: Wed, 26 Nov 2003 12:20:36 -0800 [thread overview]
Message-ID: <20031126122036.6389c773.akpm@osdl.org> (raw)
In-Reply-To: <22420000.1069877625@[10.10.2.4]>
"Martin J. Bligh" <mbligh@aracnet.com> wrote:
>
> Guillaume noticed this on s390 whilst writing a driver that used
> compound pages. Seems correct to me, I've tested it on i386 as
> well. The patch just makes us call free_pages_check for each element
> of a compound page.
>
> diff -purN -X /home/mbligh/.diff.exclude virgin/mm/page_alloc.c clear_dirty/mm/page_alloc.c
> --- virgin/mm/page_alloc.c 2003-10-14 15:50:36.000000000 -0700
> +++ clear_dirty/mm/page_alloc.c 2003-11-26 10:36:04.000000000 -0800
> @@ -267,8 +267,11 @@ free_pages_bulk(struct zone *zone, int c
> void __free_pages_ok(struct page *page, unsigned int order)
> {
> LIST_HEAD(list);
> + int i;
>
> mod_page_state(pgfree, 1 << order);
> + for (i = 0 ; i < (1 << order) ; ++i)
> + free_pages_check(__FUNCTION__, page + i);
hmm. How did the dirty bit get itself set?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-11-26 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-26 20:13 Martin J. Bligh
2003-11-26 20:20 ` Andrew Morton [this message]
2003-12-01 3:02 ` Guillaume Morin
2003-12-01 19:40 ` Martin J. Bligh
2003-12-02 9:55 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031126122036.6389c773.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=guillaume@morinfr.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox