From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
akpm@osdl.org, linux-arch@vger.kernel.org, linux-mm@kvack.org,
willy@debian.org
Subject: Re: TLB flush optimization on s/390.
Date: Fri, 10 Oct 2003 11:01:01 +0200 [thread overview]
Message-ID: <20031010090101.GD23672@wotan.suse.de> (raw)
In-Reply-To: <20031010015018.7afb5ca0.davem@redhat.com>
On Fri, Oct 10, 2003 at 01:50:18AM -0700, David S. Miller wrote:
> On Fri, 10 Oct 2003 10:20:14 +0200
> "Martin Schwidefsky" <schwidefsky@de.ibm.com> wrote:
>
> > Would you care to explain why this is a problem? It's a static function
> > that gets folded into another static function. I added additional arguments
> > to copy_one_pte and to avoid to make move_one_page slower I though to
> > inline it would be a good idea.
>
> On at least x86 and sparc it makes it so that GCC cannot allocate
> enough registers and it has to reload several values to the
> stack.
>
> In general when the functions are huge it never makes sense to
> inline them even if only used in one place.
Also it makes oops much easier to read when the functions are smaller ;-)
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-10-10 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-10 8:20 Martin Schwidefsky
2003-10-10 8:50 ` David S. Miller
2003-10-10 9:01 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-10-10 8:37 Martin Schwidefsky
2003-10-09 12:38 Martin Schwidefsky
2003-10-10 7:00 ` David S. Miller
2003-10-06 18:04 Martin Schwidefsky
2003-10-06 18:44 ` Matthew Wilcox
2003-10-07 8:29 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031010090101.GD23672@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schwidefsky@de.ibm.com \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox