From: "David S. Miller" <davem@redhat.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: akpm@osdl.org, willy@debian.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: TLB flush optimization on s/390.
Date: Fri, 10 Oct 2003 00:00:32 -0700 [thread overview]
Message-ID: <20031010000032.15664481.davem@redhat.com> (raw)
In-Reply-To: <20031009123844.GA464@mschwid3.boeblingen.de.ibm.com>
On Thu, 9 Oct 2003 14:38:45 +0200
Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> Ok, renamed three of the new functions. Patch @EOM.
I'm fine with everything except this:
> -static int
> -copy_one_pte(struct mm_struct *mm, pte_t *src, pte_t *dst,
> - struct pte_chain **pte_chainp)
> +static inline int
> +copy_one_pte(struct vm_area_struct *vma, unsigned long old_addr,
> + pte_t *src, pte_t *dst, struct pte_chain **pte_chainp)
There is no way you should start inling this.
At best, you should suggest such a change seperately from these API
changes you are proposing. When you mix multiple changes together you
risk the whole patch being rejected, so please avoid this in the
future.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-10-10 7:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-09 12:38 Martin Schwidefsky
2003-10-10 7:00 ` David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-10-10 8:37 Martin Schwidefsky
2003-10-10 8:20 Martin Schwidefsky
2003-10-10 8:50 ` David S. Miller
2003-10-10 9:01 ` Andi Kleen
2003-10-06 18:04 Martin Schwidefsky
2003-10-06 18:44 ` Matthew Wilcox
2003-10-07 8:29 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031010000032.15664481.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schwidefsky@de.ibm.com \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox