From: "David S. Miller" <davem@redhat.com>
To: "V. Rajesh" <vrajesh@eecs.umich.edu>
Cc: akpm@osdl.org, hch@lst.de, linux-mm@kvack.org
Subject: Re: [PATCH] fix split_vma vs. invalidate_mmap_range_list race
Date: Fri, 3 Oct 2003 22:29:21 -0700 [thread overview]
Message-ID: <20031003222921.33d5c88d.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0310032353070.26794-100000@cello.eecs.umich.edu>
On Fri, 3 Oct 2003 23:58:04 -0400 (EDT)
"V. Rajesh" <vrajesh@eecs.umich.edu> wrote:
> 4) In arch/sparc64, vm_end is updated without holding i_shared_sem.
> Check make_hugetlb_page_present. I hope that is fine, but
> I am not sure.
You can ignore this case for now if you want, the sparc64 hugetlb code
is in a state of disrepair. I plan to nearly rewrite it over the
weekend so it's more uptodate and in line with the current x86 and
ia64 hugetlb support code.
I think you are right about these races, they exist and they are
real. Someone should just make sure you haven't added any deadlock
or semaphore taking with spinlocks held in higher level callers.
I don't think your patch does, but it's something to audit.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-10-04 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-04 3:58 V. Rajesh
2003-10-04 5:29 ` David S. Miller [this message]
2003-10-04 5:40 ` Andrew Morton
2003-10-04 6:31 ` Rajesh Venkatasubramanian
2003-10-04 6:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031003222921.33d5c88d.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-mm@kvack.org \
--cc=vrajesh@eecs.umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox