* 2.6.0-test5-mm4
@ 2003-09-22 8:35 Andrew Morton
2003-09-22 12:09 ` 2.6.0-test5-mm4 Florian Schanda
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Andrew Morton @ 2003-09-22 8:35 UTC (permalink / raw)
To: linux-kernel, linux-mm
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test5/2.6.0-test5-mm4/
. A series of patches from Al Viro which introduce 32-bit dev_t support
. Various new fixes
Changes since 2.6.0-test5-mm3:
linus.patch
Latest Linus tree
-ecc-support.patch
-rt-tasks-special-vm-treatment.patch
-rt-tasks-special-vm-treatment-2.patch
-group_leader-rework.patch
-group_leader-rework-fix.patch
-claim-serio-early.patch
-reiserfs-large-file-fix.patch
-irq-vector-overflow-check.patch
-mtrr-warning-fix.patch
-nls-alias-fixes.patch
-nls-elisp-removal.patch
-sched-2.6.0-test2-mm2-A3.patch
-ppc-sched_clock.patch
-sched-balance-tuning.patch
-sched-interactivity.patch
-might_sleep-diags.patch
-agp-build-fix.patch
-slab-debug-additions.patch
-slab-debug-additions-fix.patch
-remove-smp-txt.patch
-agp-warning-fix.patch
-mwave-needs-8250.patch
-any_online_cpu-fix.patch
-numa-detection-fail-fix.patch
-misc35.patch
-reiserfs-consistency-checks.patch
-remove-dupe-SOUND_RME96XX.patch
-istallion-build-fix.patch
-flock-memleak2.patch
-init-argv-fix.patch
-ens1370-name-fix.patch
-summit-apic-numbering-rework.patch
-wanXL-driver.patch
-floppy-pending-timer-fix.patch
-remove-config_build_info.patch
-access_ok-is-likely.patch
-elv-doc.patch
-sysfs_remove_dir-leak-fix.patch
-modpost-typo-fix.patch
-sbni-compile-fix.patch
-export-new-cdev-functions.patch
-INPUT_KEYCODE-fix.patch
-hangcheck-compile-fix.patch
-fix-make-rpm.patch
-NCR5380-timeout-fix.patch
-SIGRTMAX-fix.patch
-x445-no-ioapic-check.patch
-deadline-insert_here-fix.patch
-bio_dirty_fn-release-fix.patch
-direct-io-skip-compound-pages.patch
-e1000-build-fix.patch
-right-ctrl-scancode-fix.patch
-p00001_synaptics-restore-on-close.patch
-p00002_psmouse-reset-timeout.patch
-p00003_synaptics-multi-button.patch
-p00004_synaptics-optional.patch
-p00005_synaptics-pass-through.patch
-p00006_psmouse-suspend-resume.patch
-p00007_synaptics-old-proto.patch
-synaptics-mode-set.patch
-syn-multi-btn-fix.patch
Merged
+really-fix-make-rpm.patch
Fix `make rpm'
+sysrq-cleanups.patch
cleanup some peftovers
+misc36.patch
Misc fixes
+declaration-after-statement-check.patch
Use -Wdeclaration-after-statement i the compiler supports it
-flush-invalidate-fixes-warning-fix.patch
Folded into flush-invalidate-fixes.patch
+sysfs-dentry-leak-fix.patch
Fix possible sysfs dentry leak
+filesystem-option-parsing-tweaks.patch
+filesystem-option-parsing-fixes.patch
+filesystem-option-parsing-no-alloca.patch
Fixes and cleanups for filesystem-option-parsing.patch
+node-enumeration-cleanup-fix-01.patch
Update to the NUMA node enumeration patches
+CONFIG_HUGETLBFS-sets-CONFIG_HUGETLB_PAGE.patch
Compile the arch hugetlb support if hugetlbfs is selected
+acpi-thinkpad-fix.patch
input fix
+readonly-bind-mounts.patch
Support readonly mount --bind (preliminary - Al needs a go at this)
+setuid-removal-fix.patch
Correctly clear setuid bits
+synaptics-fix.patch
+synaptics-multibutton-fix.patch
+synaptics-code-cleanup.patch
Synaptics work
+smbfs-nls-fix.patch
SMBFS fix
+KD28-reiserfs-B5.patch
+KD29-drm-B5.patch
+KD30-xfs-B5.patch
+KD31-tty_devnum-B5.patch
+KD32-nfs-B5.patch
+KD33-jfs-B5.patch
+KD34-jffs2-B5.patch
+KD35-md-B5.patch
+KD36-dm-B5.patch
+KD37-misc3-B5.patch
+KD38-syscalls-B5.patch
+KD39-loop-B5.patch
+KD40-coda-B5.patch
+KD41-stat-B5.patch
+KD42-32bit-B5.patch
+KD43-real32-B5.patch
32-bit dev_t
+keyboard-resend-fix-fix.patch
Fix keyboard-resend-fix.patch for ppc64 and others.
All 158 patches:
linus.patch
cset-20030917_2214.txt.gz
mm.patch
add -mmN to EXTRAVERSION
kgdb-ga.patch
kgdb stub for ia32 (George Anzinger's one)
kgdbL warning fix
kgdb-buff-too-big.patch
kgdb buffer overflow fix
kgdb-warning-fix.patch
kgdbL warning fix
kgdb-build-fix.patch
kgdb-spinlock-fix.patch
kgdb-fix-debug-info.patch
kgdb: CONFIG_DEBUG_INFO fix
kgdb-cpumask_t.patch
kgdb-x86_64-fixes.patch
x86_64 fixes
kgdb-over-ethernet.patch
kgdb-over-ethernet patch
kgdb-over-ethernet-fixes.patch
kgdb-over-ethernet fixlets
kgdb-CONFIG_NET_POLL_CONTROLLER.patch
kgdb: replace CONFIG_KGDB with CONFIG_NET_RX_POLL in net drivers
kgdb-handle-stopped-NICs.patch
kgdb: handle netif_stopped NICs
eepro100-poll-controller.patch
tlan-poll_controller.patch
tulip-poll_controller.patch
tg3-poll_controller.patch
kgdb: tg3 poll_controller
kgdb-eth-smp-fix.patch
kgdb-over-ethernet: fix SMP
kgdb-eth-reattach.patch
kgdb-skb_reserve-fix.patch
kgdb-over-ethernet: skb_reserve() fix
acpi-20030916.patch
acpi-20030916
separate-output-dir.patch
kbuild: Separate output directory support
really-fix-make-rpm.patch
Really fix `make rpm'
acpi_disabled-fix.patch
acpi_disabled fix
acpi_off-fix.patch
fix acpi=off
cfq-4.patch
CFQ io scheduler
CFQ fixes
no-unit-at-a-time.patch
Use -fno-unit-at-a-time if gcc supports it
config_spinline.patch
uninline spinlocks for profiling accuracy.
ppc64-bar-0-fix.patch
Allow PCI BARs that start at 0
ppc64-reloc_hide.patch
ppc64-semaphore-reimplementation.patch
ppc64: use the ia32 semaphore implementation
ppc64-sym2-fix.patch
ppc64 sym2 fix
sym-do-160.patch
make the SYM driver do 160 MB/sec
input-use-after-free-checks.patch
input layer debug checks
fbdev.patch
framebbuffer driver update
cursor-flashing-fix.patch
fbdev: fix cursor letovers
slab-hexdump.patch
slab: hexdump structures when things go wrong
aic7xxx-parallel-build-fix.patch
fix parallel builds for aic7xxx
ramdisk-cleanup.patch
delay-ksoftirqd-fallback.patch
Try harded in IRQ context before falling back to ksoftirqd
intel8x0-cleanup.patch
intel8x0 cleanups
mark-devfs-obsolete.patch
mark devfs obsolete
uml-update.patch
Update UML to 2.6.0-test5
md-make_request-crash-fix.patch
md: crash fix
sysfs-dput-fix.patch
sysfs dput fix
sysrq-cleanups.patch
kill some leftovers from the big sysrq syncing rewrite
misc36.patch
misc fixes
declaration-after-statement-check.patch
add -Wdeclaration-after-statement
test5-pm2.patch
test5-pm2-fix.patch
flush-invalidate-fixes.patch
memory writeback/invalidation fixes
ide_floppy-maybe-fix.patch
might fix ide_floppy
pdflush-diag.patch
joydev-exclusions.patch
joydev is too eager claiming input devices
utime-on-immutable-file-fix.patch
disallow utime{s}() on immutable or append-only files
dgap.patch
New DGAP driver
dgap-cleanups.patch
dgap driver cleanups
pdc4030-update.patch
update pdc4030 driver
ali14xx-update.patch
update ali14xx driver
dtc2278-update.patch
update dtc2278 driver
ht6560b-update.patch
update ht6560b driver
qd65xx-update.patch
update qd65xx driver
umc8672-update.patch
update umc8672 driver
kobject-oops-fixes.patch
fix oopses is kobject parent is removed before child
futex_lock-splitup.patch
Split futex global spinlock futex_lock
futex-uninlinings.patch
futex uninlining
sysfs-dentry-leak-fix.patch
sysfs dentry leak fix
filesystem-option-parsing.patch
table-driven filesystems option parsing
filesystem-option-parsing-tweaks.patch
whitespace tweaks
filesystem-option-parsing-fixes.patch
filesystem option parser: fix handling of integers
filesystem-option-parsing-no-alloca.patch
filesystem option parser: don't use alloca()
befs-use-parser.patch
BEFS: Use table-driven option parsing
do_no_page-debug.patch
node-enumeration-cleanup-01.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [1/5]
node-enumeration-cleanup-02.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [2/5]
node-enumeration-cleanup-03.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [3/5]
node-enumeration-cleanup-04.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [4/5]
node-enumeration-cleanup-05.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [5/5]
node-enumeration-cleanup-fix-01.patch
node enumeration fixes
reenable-athlon-prefetch.patch
Athlon/Opteron Prefetch Fix
hugetlbfs-accounting-fix.patch
Hugetlb FS quota accounting problem
hugetlbfs-accounting-fix tweaks
CONFIG_HUGETLBFS-sets-CONFIG_HUGETLB_PAGE.patch
make CONFIG_HUGETLB_PAGE mirror CONFIG_HUGETLBFS
zap_page_range-debug.patch
zap_page_range() debug
acpi-thinkpad-fix.patch
APCI fix for thinkpads
readonly-bind-mounts.patch
readonly mount --bind support
setuid-removal-fix.patch
setuid clearing fix
synaptics-fix.patch
Fix psmouse->pktcnt in Synaptics mode
synaptics-multibutton-fix.patch
synaptics: Don't try to handle more than eight multi buttons
synaptics-code-cleanup.patch
synaptics: Code cleanup
smbfs-nls-fix.patch
KD28-reiserfs-B5.patch
KD29-drm-B5.patch
KD30-xfs-B5.patch
KD31-tty_devnum-B5.patch
KD32-nfs-B5.patch
KD33-jfs-B5.patch
KD34-jffs2-B5.patch
KD35-md-B5.patch
KD36-dm-B5.patch
KD37-misc3-B5.patch
KD38-syscalls-B5.patch
KD39-loop-B5.patch
KD40-coda-B5.patch
KD41-stat-B5.patch
KD42-32bit-B5.patch
KD43-real32-B5.patch
psmouse_ipms2-option.patch
Force mouse detection as imps/2 (and fix my KVM switch)
i8042-history.patch
debug: i8042 history dumping
keyboard-resend-fix.patch
keyboard resend fix
keyboard-resend-fix-fix.patch
list_del-debug.patch
list_del debug check
print-build-options-on-oops.patch
print a few config options on oops
show_task-free-stack-fix.patch
show_task() fix and cleanup
oops-dump-preceding-code.patch
i386 oops output: dump preceding code
lockmeter.patch
printk-oops-mangle-fix.patch
disentangle printk's whilst oopsing on SMP
20-odirect_enable.patch
21-odirect_cruft.patch
22-read_proc.patch
23-write_proc.patch
24-commit_proc.patch
25-odirect.patch
nfs-O_DIRECT-always-enabled.patch
Force CONFIG_NFS_DIRECTIO
4g-2.6.0-test2-mm2-A5.patch
4G/4G split patch
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g/4g usercopy atomicity fix
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g/4g usercopy atomicity fix
4G/4G preempt on vstack
4G/4G: even number of kmap types
4g4g: fix __get_user in slab
4g4g: Remove extra .data.idt section definition
4g/4g linker error (overlapping sections)
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g4g: show_registers() fix
4g/4g usercopy atomicity fix
4g4g: debug flags fix
4g4g: Fix wrong asm-offsets entry
cyclone time fixmap fix
4G/4G preempt on vstack
4G/4G: even number of kmap types
4g4g: fix __get_user in slab
4g4g: Remove extra .data.idt section definition
4g/4g linker error (overlapping sections)
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g4g: show_registers() fix
4g/4g usercopy atomicity fix
4g4g: debug flags fix
4g4g: Fix wrong asm-offsets entry
cyclone time fixmap fix
4g4g-cyclone-timer-fix.patch
4g4g-copy_mount_options-fix.patch
use direct_copy_{to,from}_user for kernel access in mm/usercopy.c
4g4g-might_sleep-warning-fix.patch
4G/4G might_sleep warning fix
4g4g-pagetable-accounting-fix.patch
4g/4g pagetable accounting fix
ppc-fixes.patch
make mm4 compile on ppc
aic7xxx_old-oops-fix.patch
aio-01-retry.patch
AIO: Core retry infrastructure
Fix aio process hang on EINVAL
aio-02-lockpage_wq.patch
AIO: Async page wait
aio-03-fs_read.patch
AIO: Filesystem aio read
aio-04-buffer_wq.patch
AIO: Async buffer wait
aio-05-fs_write.patch
AIO: Filesystem aio write
aio-06-bread_wq.patch
AIO: Async block read
aio-07-ext2getblk_wq.patch
AIO: Async get block for ext2
O_SYNC-speedup-2.patch
speed up O_SYNC writes
aio-09-o_sync.patch
aio O_SYNC
aio-10-BUG-fix.patch
AIO: fix a BUG
aio-11-workqueue-flush.patch
AIO: flush workqueues before destroying ioctx'es
aio-12-readahead.patch
AIO: readahead fixes
aio-dio-no-readahead.patch
aio O_DIRECT no readahead
lock_buffer_wq-fix.patch
lock_buffer_wq fix
unuse_mm-locked.patch
AIO: hold the context lock across unuse_mm
aio-take-task_lock.patch
task task_lock in use_mm()
aio-O_SYNC-fix.patch
Unify o_sync changes for aio and regular writes
aio-O_SYNC-fix bits got lost
aio: writev nr_segs fix
aio-readahead-rework.patch
Unified page range readahead for aio and regular reads
aio-readahead-speedup.patch
Readahead issues and AIO read speedup
aio-osync-fix-2.patch
More AIO O_SYNC related fixes
gang_lookup_next.patch
Change the page gang lookup API
aio-gang_lookup-fix.patch
AIO gang lookup fixes
aio-O_SYNC-short-write-fix.patch
Fix for O_SYNC short writes
O_DIRECT-race-fixes.patch
DIO fixes forward port and AIO-DIO fix
O_DIRECT-race-fixes-fixes.patch
O_DIRECT-race-fixes-commentary.patch
O_DIRECT race fixes comments
O_DIRECT-race-fixes-fixes-2.patch
O_DRIECT race fixes fix fix fix
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: 2.6.0-test5-mm4 2003-09-22 8:35 2.6.0-test5-mm4 Andrew Morton @ 2003-09-22 12:09 ` Florian Schanda 2003-09-22 12:17 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-24 9:18 ` 2.6.0-test5-mm4 boot crash Helge Hafting 2 siblings, 0 replies; 17+ messages in thread From: Florian Schanda @ 2003-09-22 12:09 UTC (permalink / raw) To: Andrew Morton, linux-kernel, linux-mm On Monday 22 September 2003 09:35, Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test5/2 Hi, I need this patch to compile ide modules properly. Florian --- old/drivers/block/ll_rw_blk.c 2003-09-22 12:59:39.000000000 +0100 +++ linux-2.6.0-test5/drivers/block/ll_rw_blk.c 2003-09-22 13:01:46.000000000 +0100 @@ -2903,3 +2903,4 @@ EXPORT_SYMBOL(blk_run_queues); EXPORT_SYMBOL(blk_rq_bio_prep); +EXPORT_SYMBOL(blk_rq_prep_restart); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 8:35 2.6.0-test5-mm4 Andrew Morton 2003-09-22 12:09 ` 2.6.0-test5-mm4 Florian Schanda @ 2003-09-22 12:17 ` Alistair J Strachan 2003-09-22 13:48 ` 2.6.0-test5-mm4 viro ` (2 more replies) 2003-09-24 9:18 ` 2.6.0-test5-mm4 boot crash Helge Hafting 2 siblings, 3 replies; 17+ messages in thread From: Alistair J Strachan @ 2003-09-22 12:17 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel, linux-mm On Monday 22 September 2003 09:35, Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test5/2 >.6.0-test5-mm4/ > > > . A series of patches from Al Viro which introduce 32-bit dev_t support > > . Various new fixes > > Hi Andrew, -mm4 won't mount my ext3 root device whereas -mm3 will. Presumably this is some byproduct of the dev_t patches. VFS: Cannot open root device "302" or hda2. Please append correct "root=" boot option. Kernel Panic: VFS: Unable to mount root fs on hda2. One possible explanation is that I have devfs compiled into my kernel. I do not, however, have it automatically mounting on boot. It overlays /dev (which is populated with original style device nodes) after INIT has loaded. Perhaps there is some other procedure I must complete before I can use 32bit dev_t? [alistair] 01:15 PM [/usr/src/linux-2.6] egrep -e "DEVFS" -e "EXT3_FS" .config CONFIG_EXT3_FS=y CONFIG_EXT3_FS_XATTR=y CONFIG_EXT3_FS_POSIX_ACL=y CONFIG_EXT3_FS_SECURITY=y CONFIG_DEVFS_FS=y # CONFIG_DEVFS_MOUNT is not set # CONFIG_DEVFS_DEBUG is not set [alistair] 01:16 PM [/usr/src/linux-2.6] dmesg | grep p2 /dev/ide/host0/bus0/target0/lun0: p1 p2 p4 Cheers, Alistair. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 12:17 ` 2.6.0-test5-mm4 Alistair J Strachan @ 2003-09-22 13:48 ` viro 2003-09-22 14:29 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-22 14:30 ` 2.6.0-test5-mm4 Florian Schanda 2003-09-22 14:36 ` 2.6.0-test5-mm4 Zilvinas Valinskas 2 siblings, 1 reply; 17+ messages in thread From: viro @ 2003-09-22 13:48 UTC (permalink / raw) To: Alistair J Strachan; +Cc: Andrew Morton, linux-kernel, linux-mm On Mon, Sep 22, 2003 at 01:17:42PM +0100, Alistair J Strachan wrote: > One possible explanation is that I have devfs compiled into my kernel. I do > not, however, have it automatically mounting on boot. It overlays /dev (which > is populated with original style device nodes) after INIT has loaded. Amazingly idiotic typo. And yes, it gets hit only if devfs is configured. diff -u B5-real32/init/do_mounts.h B5-current/init/do_mounts.h --- B5-real32/init/do_mounts.h Sun Sep 21 21:22:33 2003 +++ B5-current/init/do_mounts.h Mon Sep 22 09:41:21 2003 @@ -53,7 +53,7 @@ static inline u32 bstat(char *name) { struct stat64 stat; - if (!sys_stat64(name, &stat) != 0) + if (sys_stat64(name, &stat) != 0) return 0; if (!S_ISBLK(stat.st_mode)) return 0; @@ -65,7 +65,7 @@ static inline u32 bstat(char *name) { struct stat stat; - if (!sys_newstat(name, &stat) != 0) + if (sys_newstat(name, &stat) != 0) return 0; if (!S_ISBLK(stat.st_mode)) return 0; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 13:48 ` 2.6.0-test5-mm4 viro @ 2003-09-22 14:29 ` Alistair J Strachan 0 siblings, 0 replies; 17+ messages in thread From: Alistair J Strachan @ 2003-09-22 14:29 UTC (permalink / raw) To: viro; +Cc: Andrew Morton, linux-kernel, linux-mm On Monday 22 September 2003 14:48, you wrote: > On Mon, Sep 22, 2003 at 01:17:42PM +0100, Alistair J Strachan wrote: > > One possible explanation is that I have devfs compiled into my kernel. I > > do not, however, have it automatically mounting on boot. It overlays /dev > > (which is populated with original style device nodes) after INIT has > > loaded. > > Amazingly idiotic typo. And yes, it gets hit only if devfs is configured. > > diff -u B5-real32/init/do_mounts.h B5-current/init/do_mounts.h > --- B5-real32/init/do_mounts.h Sun Sep 21 21:22:33 2003 > +++ B5-current/init/do_mounts.h Mon Sep 22 09:41:21 2003 > @@ -53,7 +53,7 @@ > static inline u32 bstat(char *name) > { > struct stat64 stat; > - if (!sys_stat64(name, &stat) != 0) > + if (sys_stat64(name, &stat) != 0) > return 0; > if (!S_ISBLK(stat.st_mode)) > return 0; > @@ -65,7 +65,7 @@ > static inline u32 bstat(char *name) > { > struct stat stat; > - if (!sys_newstat(name, &stat) != 0) > + if (sys_newstat(name, &stat) != 0) > return 0; > if (!S_ISBLK(stat.st_mode)) > return 0; Thanks for that. It's working fine now. Cheers, Alistair. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 12:17 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-22 13:48 ` 2.6.0-test5-mm4 viro @ 2003-09-22 14:30 ` Florian Schanda 2003-09-22 14:36 ` 2.6.0-test5-mm4 Zilvinas Valinskas 2 siblings, 0 replies; 17+ messages in thread From: Florian Schanda @ 2003-09-22 14:30 UTC (permalink / raw) To: Alistair J Strachan, Andrew Morton; +Cc: linux-kernel, linux-mm -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Monday 22 September 2003 13:17, Alistair J Strachan wrote: > -mm4 won't mount my ext3 root device whereas -mm3 will. Presumably this is > some byproduct of the dev_t patches. I don't think this has to do with ext3, since my root xfs partition can't be mounted either. > VFS: Cannot open root device "302" or hda2. > Please append correct "root=" boot option. > Kernel Panic: VFS: Unable to mount root fs on hda2. same over here, except replace hda2 with sda3 and (302 with 803 of couse). > One possible explanation is that I have devfs compiled into my kernel. I do > not, however, have it automatically mounting on boot. It overlays /dev > (which is populated with original style device nodes) after INIT has > loaded. I disabled mount at root and created some device nodes, but it still doesn't work, befor that I had pure devfs. Reading the config help for devfs says it's obsoleted, and stripped down to a "bare minimum to not break anyting". Does that "bare minimum" include hard disks? Florian -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQE/bwdvfCf8muQVS4cRAmQ0AJ9N6WBJIOKholW9Rf2QV6wdxlWyHACeNsoP niBAErfeLd0NR0WR6ElKOhU= =Iysp -----END PGP SIGNATURE----- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 12:17 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-22 13:48 ` 2.6.0-test5-mm4 viro 2003-09-22 14:30 ` 2.6.0-test5-mm4 Florian Schanda @ 2003-09-22 14:36 ` Zilvinas Valinskas 2003-09-22 13:49 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-22 18:55 ` 2.6.0-test5-mm4 Andrew Morton 2 siblings, 2 replies; 17+ messages in thread From: Zilvinas Valinskas @ 2003-09-22 14:36 UTC (permalink / raw) To: Alistair J Strachan; +Cc: Andrew Morton, linux-kernel, linux-mm On Mon, Sep 22, 2003 at 01:17:42PM +0100, Alistair J Strachan wrote: > On Monday 22 September 2003 09:35, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test5/2 > >.6.0-test5-mm4/ > > > > > > . A series of patches from Al Viro which introduce 32-bit dev_t support > > > > . Various new fixes > > > > > > Hi Andrew, > > -mm4 won't mount my ext3 root device whereas -mm3 will. Presumably this is > some byproduct of the dev_t patches. > > VFS: Cannot open root device "302" or hda2. > Please append correct "root=" boot option. > Kernel Panic: VFS: Unable to mount root fs on hda2. Do you use devfsd ? I had to specify root like this : root=/dev/ide/host0/bus0/target0/lun0/part5 then it worked just fine. Btw Andrew , this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver from http://w1.894.telia.com/~u89404340/touchpad/index.html. -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/ 2", "ImPS/2", "ImExPS/2", "Synaptics"}; +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"}; > > One possible explanation is that I have devfs compiled into my kernel. I do > not, however, have it automatically mounting on boot. It overlays /dev (which > is populated with original style device nodes) after INIT has loaded. > > Perhaps there is some other procedure I must complete before I can use 32bit > dev_t? > > [alistair] 01:15 PM [/usr/src/linux-2.6] egrep -e "DEVFS" -e "EXT3_FS" .config > CONFIG_EXT3_FS=y > CONFIG_EXT3_FS_XATTR=y > CONFIG_EXT3_FS_POSIX_ACL=y > CONFIG_EXT3_FS_SECURITY=y > CONFIG_DEVFS_FS=y > # CONFIG_DEVFS_MOUNT is not set > # CONFIG_DEVFS_DEBUG is not set > > [alistair] 01:16 PM [/usr/src/linux-2.6] dmesg | grep p2 > /dev/ide/host0/bus0/target0/lun0: p1 p2 p4 > > Cheers, > Alistair. > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 14:36 ` 2.6.0-test5-mm4 Zilvinas Valinskas @ 2003-09-22 13:49 ` Alistair J Strachan 2003-09-22 13:54 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-22 18:55 ` 2.6.0-test5-mm4 Andrew Morton 1 sibling, 1 reply; 17+ messages in thread From: Alistair J Strachan @ 2003-09-22 13:49 UTC (permalink / raw) To: Zilvinas Valinskas; +Cc: Andrew Morton, linux-kernel, linux-mm On Monday 22 September 2003 15:36, Zilvinas Valinskas wrote: [snip] > > > > VFS: Cannot open root device "302" or hda2. > > Please append correct "root=" boot option. > > Kernel Panic: VFS: Unable to mount root fs on hda2. > > Do you use devfsd ? > No. As I said, I mount /dev with mount -t devfs devfs /dev in a sysinit bootscript. Whether it's in the kernel or not shouldn't make any difference. Maybe I just need to reissue LILO after booting the 32bit dev_t kernel? > I had to specify root like this : > root=/dev/ide/host0/bus0/target0/lun0/part5 then it worked just fine. > I'll try that, thanks. But I have this in lilo.conf: boot=/dev/discs/disc0/disc root=/dev/discs/disc0/part2 /dev/discs is indeed a symlink, but it should be resolved when LILO is installed, i.e., prior to the reboot. Why has this behaviour changed? Cheers, Alistair. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 13:49 ` 2.6.0-test5-mm4 Alistair J Strachan @ 2003-09-22 13:54 ` Alistair J Strachan 0 siblings, 0 replies; 17+ messages in thread From: Alistair J Strachan @ 2003-09-22 13:54 UTC (permalink / raw) To: Zilvinas Valinskas; +Cc: Andrew Morton, linux-kernel, linux-mm On Monday 22 September 2003 14:49, Alistair J Strachan wrote: [snip] > > I'll try that, thanks. But I have this in lilo.conf: > > boot=/dev/discs/disc0/disc > root=/dev/discs/disc0/part2 > > /dev/discs is indeed a symlink, but it should be resolved when LILO is > installed, i.e., prior to the reboot. Why has this behaviour changed? > Changing it as per your suggestion makes no difference. I still cannot boot, and the error is identical. Disregard my last email. Cheers, Alistair. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 14:36 ` 2.6.0-test5-mm4 Zilvinas Valinskas 2003-09-22 13:49 ` 2.6.0-test5-mm4 Alistair J Strachan @ 2003-09-22 18:55 ` Andrew Morton 2003-09-22 21:27 ` 2.6.0-test5-mm4 Peter Osterlund 2003-09-22 21:44 ` 2.6.0-test5-mm4 Vojtech Pavlik 1 sibling, 2 replies; 17+ messages in thread From: Andrew Morton @ 2003-09-22 18:55 UTC (permalink / raw) To: Zilvinas Valinskas; +Cc: alistair, linux-kernel, linux-mm, Vojtech Pavlik Zilvinas Valinskas <zilvinas@gemtek.lt> wrote: > > Btw Andrew , > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver > from http://w1.894.telia.com/~u89404340/touchpad/index.html. > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/ > 2", "ImPS/2", "ImExPS/2", "Synaptics"}; > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"}; You mean it breaks the XFree driver? Is it just a matter of editing XF86Config to tell it the new protocl name? Either way, it looks like a change which should be reverted? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 18:55 ` 2.6.0-test5-mm4 Andrew Morton @ 2003-09-22 21:27 ` Peter Osterlund 2003-09-22 21:45 ` 2.6.0-test5-mm4 Vojtech Pavlik 2003-09-22 21:44 ` 2.6.0-test5-mm4 Vojtech Pavlik 1 sibling, 1 reply; 17+ messages in thread From: Peter Osterlund @ 2003-09-22 21:27 UTC (permalink / raw) To: Andrew Morton Cc: Zilvinas Valinskas, alistair, linux-kernel, linux-mm, Vojtech Pavlik Andrew Morton <akpm@osdl.org> writes: > Zilvinas Valinskas <zilvinas@gemtek.lt> wrote: > > > > Btw Andrew , > > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver > > from http://w1.894.telia.com/~u89404340/touchpad/index.html. > > > > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/ > > 2", "ImPS/2", "ImExPS/2", "Synaptics"}; > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"}; > > You mean it breaks the XFree driver? Is it just a matter of editing > XF86Config to tell it the new protocl name? It breaks the event device auto detection, which works by parsing /proc/bus/input/devices. The protocol name is hard coded so you can't just change the XF86Config file. > Either way, it looks like a change which should be reverted? I think the new protocol name is better, so why not just fix the X driver instead. Here is a fixed version: http://w1.894.telia.com/~u89404340/touchpad/synaptics-0.11.4.tar.bz2 -- Peter Osterlund - petero2@telia.com http://w1.894.telia.com/~u89404340 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 21:27 ` 2.6.0-test5-mm4 Peter Osterlund @ 2003-09-22 21:45 ` Vojtech Pavlik 2003-09-25 0:13 ` 2.6.0-test5-mm4 Peter Osterlund 0 siblings, 1 reply; 17+ messages in thread From: Vojtech Pavlik @ 2003-09-22 21:45 UTC (permalink / raw) To: Peter Osterlund Cc: Andrew Morton, Zilvinas Valinskas, alistair, linux-kernel, linux-mm, Vojtech Pavlik On Mon, Sep 22, 2003 at 11:27:17PM +0200, Peter Osterlund wrote: > Andrew Morton <akpm@osdl.org> writes: > > > Zilvinas Valinskas <zilvinas@gemtek.lt> wrote: > > > > > > Btw Andrew , > > > > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver > > > from http://w1.894.telia.com/~u89404340/touchpad/index.html. > > > > > > > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/ > > > 2", "ImPS/2", "ImExPS/2", "Synaptics"}; > > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"}; > > > > You mean it breaks the XFree driver? Is it just a matter of editing > > XF86Config to tell it the new protocl name? > > It breaks the event device auto detection, which works by parsing > /proc/bus/input/devices. The protocol name is hard coded so you can't > just change the XF86Config file. > > > Either way, it looks like a change which should be reverted? > > I think the new protocol name is better, so why not just fix the X > driver instead. Here is a fixed version: > > http://w1.894.telia.com/~u89404340/touchpad/synaptics-0.11.4.tar.bz2 I'd suggest the driver either checks the BUS/VENDOR/DEVICE ids or the bitfields for the pad, not the name. Names are unreliable ... -- Vojtech Pavlik SuSE Labs, SuSE CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 21:45 ` 2.6.0-test5-mm4 Vojtech Pavlik @ 2003-09-25 0:13 ` Peter Osterlund 2003-09-25 12:43 ` 2.6.0-test5-mm4 Vojtech Pavlik 0 siblings, 1 reply; 17+ messages in thread From: Peter Osterlund @ 2003-09-25 0:13 UTC (permalink / raw) To: Vojtech Pavlik Cc: Andrew Morton, Zilvinas Valinskas, alistair, linux-kernel, linux-mm Vojtech Pavlik <vojtech@suse.cz> writes: > On Mon, Sep 22, 2003 at 11:27:17PM +0200, Peter Osterlund wrote: > > Andrew Morton <akpm@osdl.org> writes: > > > > > Zilvinas Valinskas <zilvinas@gemtek.lt> wrote: > > > > > > > > Btw Andrew , > > > > > > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver > > > > from http://w1.894.telia.com/~u89404340/touchpad/index.html. > > > > > > > > > > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/ > > > > 2", "ImPS/2", "ImExPS/2", "Synaptics"}; > > > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"}; > > > > > > You mean it breaks the XFree driver? Is it just a matter of editing > > > XF86Config to tell it the new protocl name? > > > > It breaks the event device auto detection, which works by parsing > > /proc/bus/input/devices. The protocol name is hard coded so you can't > > just change the XF86Config file. > > > > > Either way, it looks like a change which should be reverted? > > > > I think the new protocol name is better, so why not just fix the X > > driver instead. Here is a fixed version: > > > > http://w1.894.telia.com/~u89404340/touchpad/synaptics-0.11.4.tar.bz2 > > I'd suggest the driver either checks the BUS/VENDOR/DEVICE ids or the > bitfields for the pad, not the name. Names are unreliable ... OK, this is now implemented in version 0.11.5, which I just uploaded to my web site. This version also adds support for the new events ABS_TOOL_WIDTH, BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP and BTN_TOOL_TRIPLETAP. -- Peter Osterlund - petero2@telia.com http://w1.894.telia.com/~u89404340 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-25 0:13 ` 2.6.0-test5-mm4 Peter Osterlund @ 2003-09-25 12:43 ` Vojtech Pavlik 0 siblings, 0 replies; 17+ messages in thread From: Vojtech Pavlik @ 2003-09-25 12:43 UTC (permalink / raw) To: Peter Osterlund Cc: Vojtech Pavlik, Andrew Morton, Zilvinas Valinskas, alistair, linux-kernel, linux-mm On Thu, Sep 25, 2003 at 02:13:04AM +0200, Peter Osterlund wrote: > Vojtech Pavlik <vojtech@suse.cz> writes: > > > On Mon, Sep 22, 2003 at 11:27:17PM +0200, Peter Osterlund wrote: > > > Andrew Morton <akpm@osdl.org> writes: > > > > > > > Zilvinas Valinskas <zilvinas@gemtek.lt> wrote: > > > > > > > > > > Btw Andrew , > > > > > > > > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver > > > > > from http://w1.894.telia.com/~u89404340/touchpad/index.html. > > > > > > > > > > > > > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/ > > > > > 2", "ImPS/2", "ImExPS/2", "Synaptics"}; > > > > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"}; > > > > > > > > You mean it breaks the XFree driver? Is it just a matter of editing > > > > XF86Config to tell it the new protocl name? > > > > > > It breaks the event device auto detection, which works by parsing > > > /proc/bus/input/devices. The protocol name is hard coded so you can't > > > just change the XF86Config file. > > > > > > > Either way, it looks like a change which should be reverted? > > > > > > I think the new protocol name is better, so why not just fix the X > > > driver instead. Here is a fixed version: > > > > > > http://w1.894.telia.com/~u89404340/touchpad/synaptics-0.11.4.tar.bz2 > > > > I'd suggest the driver either checks the BUS/VENDOR/DEVICE ids or the > > bitfields for the pad, not the name. Names are unreliable ... > > OK, this is now implemented in version 0.11.5, which I just uploaded > to my web site. This version also adds support for the new events > ABS_TOOL_WIDTH, BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP and > BTN_TOOL_TRIPLETAP. Great, thanks. -- Vojtech Pavlik SuSE Labs, SuSE CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 2003-09-22 18:55 ` 2.6.0-test5-mm4 Andrew Morton 2003-09-22 21:27 ` 2.6.0-test5-mm4 Peter Osterlund @ 2003-09-22 21:44 ` Vojtech Pavlik 1 sibling, 0 replies; 17+ messages in thread From: Vojtech Pavlik @ 2003-09-22 21:44 UTC (permalink / raw) To: Andrew Morton Cc: Zilvinas Valinskas, alistair, linux-kernel, linux-mm, Vojtech Pavlik On Mon, Sep 22, 2003 at 11:55:09AM -0700, Andrew Morton wrote: > Zilvinas Valinskas <zilvinas@gemtek.lt> wrote: > > > > Btw Andrew , > > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver > > from http://w1.894.telia.com/~u89404340/touchpad/index.html. > > > > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/ > > 2", "ImPS/2", "ImExPS/2", "Synaptics"}; > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"}; > > You mean it breaks the XFree driver? Is it just a matter of editing > XF86Config to tell it the new protocl name? Ouch? This is just an information string, it is not supposed to be used anywhere except printks etc ... I really HOPE nobody is parsing these strings. Before the patch, the input_dev.name string said "Synaptics Synaptics Pad", which kind of didn't make much sense. Since it's a concatenation of protocol, vendor and device names, it now says "SynPS/2 Synaptics Pad", which sounds a bit better. > Either way, it looks like a change which should be reverted? If it breaks anything, that needs to be fixed in what it broke, because nothing should depend on this. If it does, then that's a big bug. -- Vojtech Pavlik SuSE Labs, SuSE CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 boot crash 2003-09-22 8:35 2.6.0-test5-mm4 Andrew Morton 2003-09-22 12:09 ` 2.6.0-test5-mm4 Florian Schanda 2003-09-22 12:17 ` 2.6.0-test5-mm4 Alistair J Strachan @ 2003-09-24 9:18 ` Helge Hafting 2003-09-24 9:57 ` viro 2 siblings, 1 reply; 17+ messages in thread From: Helge Hafting @ 2003-09-24 9:18 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel, linux-mm test5-mm4 crashed during RAID-1 autodetection and setup. It got as far as: md: created md0 md: bind<hda1> md: bind<hdb1> md: running: <hdb1><hda1> After this, I usually get this (from test5-mm3 dmesg): raid1: raid set md0 active with 2 out of 2 mirrors md: ... autorun DONE. VFS: Mounted root (ext2 filesystem) readonly. Instead, I got the dump at the end of this message. I'm using devfs and Viro's compile fix for devfs in mm4. The root fs is on raid-1, the raid-1 gets autodetected. The kernel has no module support, and no initrd. Here's the dump: Unable to handle null pointer deref at virtual address 00000000 eip c02b7d1e eip at md_probe PREEMPT process swapper pid:1 Trace: invalidate_inode_pages do_md_run printk autorun_array autorun_devices mddev_put autostart_arrays igrab md_ioctl devfs_open dentry_open filp_open blkdev_ioctl sys_ioctl md_run_setup prepare_namespace init init kernel_thread_helper Attempted to kill init! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: 2.6.0-test5-mm4 boot crash 2003-09-24 9:18 ` 2.6.0-test5-mm4 boot crash Helge Hafting @ 2003-09-24 9:57 ` viro 0 siblings, 0 replies; 17+ messages in thread From: viro @ 2003-09-24 9:57 UTC (permalink / raw) To: Helge Hafting; +Cc: Andrew Morton, linux-kernel, linux-mm On Wed, Sep 24, 2003 at 11:18:47AM +0200, Helge Hafting wrote: > Unable to handle null pointer deref at virtual address 00000000 > eip c02b7d1e eip at md_probe Oh, boy... OK, I see what happens and it's _ugly_. md_probe() is misused there big way. The minimal fix is to revert the cleanup in md_probe() - replace int unit = *part; with int unit = MINOR(dev); However, that is crap solution. The problem is that md_probe() is called directly with bogus arguments - not only part is NULL (which triggers the oops), but dev (which is supposed to be dev_t value) is actually mdidx(mddev). Cleaner fix follows, but we really need to get the situation with gendisk allocations into the sane shape there. Sigh... diff -urN B5-tty_devnum-fix/drivers/md/md.c B5-current/drivers/md/md.c --- B5-tty_devnum-fix/drivers/md/md.c Tue Sep 23 04:16:30 2003 +++ B5-current/drivers/md/md.c Wed Sep 24 05:44:27 2003 @@ -1500,6 +1500,7 @@ mdk_rdev_t *rdev; struct gendisk *disk; char b[BDEVNAME_SIZE]; + int unit; if (list_empty(&mddev->disks)) { MD_BUG(); @@ -1591,8 +1592,9 @@ invalidate_bdev(rdev->bdev, 0); } - md_probe(mdidx(mddev), NULL, NULL); - disk = disks[mdidx(mddev)]; + unit = mdidx(mddev); + md_probe(0, &unit, NULL); + disk = disks[unit]; if (!disk) return -ENOMEM; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2003-09-25 12:43 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2003-09-22 8:35 2.6.0-test5-mm4 Andrew Morton 2003-09-22 12:09 ` 2.6.0-test5-mm4 Florian Schanda 2003-09-22 12:17 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-22 13:48 ` 2.6.0-test5-mm4 viro 2003-09-22 14:29 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-22 14:30 ` 2.6.0-test5-mm4 Florian Schanda 2003-09-22 14:36 ` 2.6.0-test5-mm4 Zilvinas Valinskas 2003-09-22 13:49 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-22 13:54 ` 2.6.0-test5-mm4 Alistair J Strachan 2003-09-22 18:55 ` 2.6.0-test5-mm4 Andrew Morton 2003-09-22 21:27 ` 2.6.0-test5-mm4 Peter Osterlund 2003-09-22 21:45 ` 2.6.0-test5-mm4 Vojtech Pavlik 2003-09-25 0:13 ` 2.6.0-test5-mm4 Peter Osterlund 2003-09-25 12:43 ` 2.6.0-test5-mm4 Vojtech Pavlik 2003-09-22 21:44 ` 2.6.0-test5-mm4 Vojtech Pavlik 2003-09-24 9:18 ` 2.6.0-test5-mm4 boot crash Helge Hafting 2003-09-24 9:57 ` viro
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox