From: Jens Axboe <axboe@suse.de>
To: Nick Piggin <piggin@cyberone.com.au>
Cc: Andrew Morton <akpm@osdl.org>,
"Martin J. Bligh" <mbligh@aracnet.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.6.0-test2-mm5
Date: Thu, 7 Aug 2003 10:44:52 +0200 [thread overview]
Message-ID: <20030807084451.GA858@suse.de> (raw)
In-Reply-To: <3F32108A.2010000@cyberone.com.au>
On Thu, Aug 07 2003, Nick Piggin wrote:
> --- linux-2.6/drivers/block/as-iosched.c.orig 2003-08-07 18:33:06.000000000 +1000
> +++ linux-2.6/drivers/block/as-iosched.c 2003-08-07 18:36:03.000000000 +1000
> @@ -1198,8 +1198,10 @@ static int as_dispatch_request(struct as
> */
> goto dispatch_writes;
>
> - if (ad->batch_data_dir == REQ_ASYNC)
> + if (ad->batch_data_dir == REQ_ASYNC) {
> + WARN_ON(ad->new_batch || ad->changed_batch);
combining debug checks like this is generally a bad idea imho, since you
don't know which of them triggered...
--
Jens Axboe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-08-07 8:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-07 5:37 2.6.0-test2-mm5 Andrew Morton
2003-08-07 6:31 ` 2.6.0-test2-mm5 Martin J. Bligh
2003-08-07 7:05 ` 2.6.0-test2-mm5 Andrew Morton
2003-08-07 8:29 ` 2.6.0-test2-mm5 Nick Piggin
2003-08-07 8:40 ` 2.6.0-test2-mm5 Nick Piggin
2003-08-07 8:43 ` 2.6.0-test2-mm5 Nick Piggin
2003-08-07 18:30 ` 2.6.0-test2-mm5 Martin J. Bligh
2003-08-07 8:44 ` Jens Axboe [this message]
2003-08-07 6:33 ` 2.6.0-test2-mm5 William Lee Irwin III
2003-08-07 6:44 ` 2.6.0-test2-mm5 Andrew Morton
2003-08-07 8:00 ` 2.6.0-test2-mm5 Christoph Hellwig
2003-08-07 21:21 ` 2.6.0-test2-mm5 Marcelo Tosatti
2003-08-07 21:24 ` 2.6.0-test2-mm5 William Lee Irwin III
2003-08-07 21:28 ` 2.6.0-test2-mm5 Andrew Morton
2003-08-07 22:07 ` 2.6.0-test2-mm5 Marcelo Tosatti
2003-08-08 20:51 ` 2.6.0-test2-mm5 Marcelo Tosatti
2003-08-08 21:36 ` 2.6.0-test2-mm5 William Lee Irwin III
2003-08-07 23:47 ` 2.6.0-test2-mm5 Martin J. Bligh
2003-08-08 0:16 ` 2.6.0-test2-mm5 William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030807084451.GA858@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@aracnet.com \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox