linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Schlichter <schlicht@uni-mannheim.de>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH] Compile fix for 2.5.70-mm8/drivers/usb/media/vicam.c
Date: Wed, 11 Jun 2003 12:13:53 +0200	[thread overview]
Message-ID: <200306111213.59596.schlicht@uni-mannheim.de> (raw)
In-Reply-To: <20030611013325.355a6184.akpm@digeo.com>


[-- Attachment #1.1: Type: text/plain, Size: 265 bytes --]

Hi,

it seems a copy_from_user() cleanup for the file mentioned above introduced 
compile errors. This cleanup is (not yet) present in linus' tree and I do not 
know who was the author of it, so I send this patch to you...

Best regards
  Thomas Schlichter

[-- Attachment #1.2: vicam.diff --]
[-- Type: text/x-diff, Size: 941 bytes --]

--- linux-2.5.70-mm8/drivers/usb/media/vicam.c.orig	Wed Jun 11 11:43:48 2003
+++ linux-2.5.70-mm8/drivers/usb/media/vicam.c	Wed Jun 11 11:47:25 2003
@@ -618,13 +618,13 @@
 				break;
 			}
 
-			DBG("VIDIOCSPICT depth = %d, pal = %d\n", vp->depth,
-			    vp->palette);
+			DBG("VIDIOCSPICT depth = %d, pal = %d\n", vp.depth,
+			    vp.palette);
 
-			cam->gain = vp->brightness >> 8;
+			cam->gain = vp.brightness >> 8;
 
-			if (vp->depth != 24
-			    || vp->palette != VIDEO_PALETTE_RGB24)
+			if (vp.depth != 24
+			    || vp.palette != VIDEO_PALETTE_RGB24)
 				retval = -EINVAL;
 
 			break;
@@ -663,9 +663,9 @@
 				retval = -EFAULT;
 				break;
 			}
-			DBG("VIDIOCSWIN %d x %d\n", vw->width, vw->height);
+			DBG("VIDIOCSWIN %d x %d\n", vw.width, vw.height);
 
-			if ( vw->width != 320 || vw->height != 240 )
+			if ( vw.width != 320 || vw.height != 240 )
 				retval = -EFAULT;
 			
 			break;

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2003-06-11 10:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-11  8:33 2.5.70-mm8 Andrew Morton
2003-06-11  9:17 ` 2.5.70-mm8 Stefano Rivoir
2003-06-11  9:27   ` 2.5.70-mm8 Andrew Morton
2003-06-11  9:31   ` 2.5.70-mm8 Thomas Schlichter
2003-06-11 10:13 ` Thomas Schlichter [this message]
2003-06-11 11:08 ` 2.5.70-mm8 - RAID1 and fb works! Helge Hafting
2003-06-11 15:57   ` Helge Hafting
2003-06-11 11:56 ` [2.5.70-mm8] NETDEV WATCHDOG: eth0: transmit timed out Thomas Schlichter
2003-06-11 13:16   ` Thomas Schlichter
2003-06-11 15:25     ` Thomas Schlichter
2003-06-11 18:56       ` Andrew Morton
2003-06-12 11:59         ` Thomas Schlichter
2003-06-12  5:20 ` 2.5.70-mm8 Jordan Breeding
2003-06-12  5:31   ` 2.5.70-mm8 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200306111213.59596.schlicht@uni-mannheim.de \
    --to=schlicht@uni-mannheim.de \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox