From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: [RFC][PATCH] Convert do_no_page() to a hook to avoid DFS race
Date: Sat, 31 May 2003 16:51:23 -0700 [thread overview]
Message-ID: <20030531235123.GC1408@us.ibm.com> (raw)
In-Reply-To: <20030530180027.75680efd.akpm@digeo.com>
On Fri, May 30, 2003 at 06:00:27PM -0700, Andrew Morton wrote:
> "Paul E. McKenney" <paulmck@us.ibm.com> wrote:
> > There
> > is still an inlined do_no_page() wrapper due to the fact that
> > do_anonymous_page() requires that the mm->page_table_lock be
> > held on entry, while the ->nopage callouts require that this
> > lock be dropped.
>
> I sugest you change the ->nopage definition so that page_table_lock is held
> on entry to ->nopage, and ->nopage must drop it at some point. This gives
> the nopage implementations some more flexibility and may perhaps eliminate
> that special case?
Will do!
> > This patch is untested.
>
> I don't think there's a lot of point in making changes until the code which
> requires those changes is accepted into the tree. Otherwise it may be
> pointless churn, and there's nothing in-tree to exercise the new features.
A GPLed use of these DFS features is expected Real Soon Now...
Thanx, Paul
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-05-31 23:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-30 23:41 Paul E. McKenney
2003-05-31 1:00 ` Andrew Morton
2003-05-31 23:51 ` Paul E. McKenney [this message]
2003-08-09 18:50 ` Christoph Hellwig
2003-08-10 12:06 ` Paul E. McKenney
2003-06-01 19:33 ` Paul E. McKenney
2003-05-31 8:46 ` Always passing mm and vma down (was: [RFC][PATCH] Convert do_no_page() to a hook to avoid DFS race) Ingo Oeser
2003-05-31 23:48 ` Paul E. McKenney
2003-06-01 12:22 ` Andrea Arcangeli
2003-06-01 20:00 ` Paul E. McKenney
2003-06-02 8:32 ` Arjan van de Ven
2003-06-02 13:13 ` Paul E. McKenney
2003-06-04 10:38 ` Andrea Arcangeli
2003-06-07 16:29 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030531235123.GC1408@us.ibm.com \
--to=paulmck@us.ibm.com \
--cc=akpm@digeo.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox