From: Daniel Phillips <phillips@arcor.de>
To: arjanv@redhat.com, Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-mm@kvack.org, akpm@digeo.com
Subject: Re: [PATCH] dirty bit clearing on s390.
Date: Thu, 22 May 2003 16:21:36 +0200 [thread overview]
Message-ID: <200305221621.36656.phillips@arcor.de> (raw)
In-Reply-To: <1053603729.2360.0.camel@laptop.fenrus.com>
On Thursday 22 May 2003 13:42, Arjan van de Ven wrote:
> On Thu, 2003-05-22 at 13:20, Martin Schwidefsky wrote:
> > Our solution is to move the clearing of the storage key (dirty bit)
> > from set_pte to SetPageUptodate. A patch that implements this is
> > attached. What do you think ?
>
> Is there anything that prevents a thread mmaping the page to redirty it
> before the kernel marks it uptodate ?
The storage key is only supposed to be cleared the first time a page is
entered into any process page table. The theory is that the s390 hook in
SetPageUptodate can figure that out reliably (this theory needs to be
examined closely). If it can know that, then it also knows no other page
table is mapping the page, so no dirty events can get lost.
Regards,
Daniel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-05-22 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 11:20 Martin Schwidefsky
2003-05-22 11:40 ` Christoph Hellwig
2003-05-22 11:42 ` Arjan van de Ven
2003-05-22 14:21 ` Daniel Phillips [this message]
2003-05-22 14:35 ` Rik van Riel
2003-05-22 15:18 ` Daniel Phillips
2003-05-23 22:52 ` Andrew Morton
2003-05-26 6:24 Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305221621.36656.phillips@arcor.de \
--to=phillips@arcor.de \
--cc=akpm@digeo.com \
--cc=arjanv@redhat.com \
--cc=linux-mm@kvack.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox