From: Christoph Hellwig <hch@infradead.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-mm@kvack.org, akpm@digeo.com, phillips@arcor.de
Subject: Re: [PATCH] dirty bit clearing on s390.
Date: Thu, 22 May 2003 12:40:18 +0100 [thread overview]
Message-ID: <20030522124018.A20638@infradead.org> (raw)
In-Reply-To: <20030522112000.GA2597@mschwid3.boeblingen.de.ibm.com>; from schwidefsky@de.ibm.com on Thu, May 22, 2003 at 01:20:00PM +0200
On Thu, May 22, 2003 at 01:20:00PM +0200, Martin Schwidefsky wrote:
> +#ifndef arch_set_page_uptodate
> +#define arch_set_page_uptodate(page)
> +#endif
> +
> #define PageUptodate(page) test_bit(PG_uptodate, &(page)->flags)
> -#define SetPageUptodate(page) set_bit(PG_uptodate, &(page)->flags)
> +#define SetPageUptodate(page) \
> + do { \
> + arch_set_page_uptodate(page); \
> + set_bit(PG_uptodate, &(page)->flags); \
> + } while (0)
> #define ClearPageUptodate(page) clear_bit(PG_uptodate, &(page)->flags)
I guess it would be nicer if the arch could just overrid SetPageUptodate
completly e.g.
#ifndef SetPageUptodate
#define SetPageUptodate(page) set_bit(PG_uptodate, &(page)->flags)
#endif
with a big comment explaining why s390 needs it. Else it looks fine to me.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-05-22 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 11:20 Martin Schwidefsky
2003-05-22 11:40 ` Christoph Hellwig [this message]
2003-05-22 11:42 ` Arjan van de Ven
2003-05-22 14:21 ` Daniel Phillips
2003-05-22 14:35 ` Rik van Riel
2003-05-22 15:18 ` Daniel Phillips
2003-05-23 22:52 ` Andrew Morton
2003-05-26 6:24 Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030522124018.A20638@infradead.org \
--to=hch@infradead.org \
--cc=akpm@digeo.com \
--cc=linux-mm@kvack.org \
--cc=phillips@arcor.de \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox