From: William Lee Irwin III <wli@holomorphy.com>
To: Helge Hafting <helgehaf@aitel.hist.no>
Cc: Andrew Morton <akpm@digeo.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
alexh@ihatent.com
Subject: Re: [PATCH] Re: 2.5.69-mm4 undefined active_load_balance
Date: Tue, 13 May 2003 14:35:27 -0700 [thread overview]
Message-ID: <20030513213527.GV8978@holomorphy.com> (raw)
In-Reply-To: <20030513213110.GA655@hh.idb.hist.no>
On Tue, May 13, 2003 at 12:38:47PM -0700, William Lee Irwin III wrote:
>> Linus just committed a patch to eliminate such offenders.
>> Do you mean #if CONFIG_NR_SIBLINGS != 0 or #ifdef CONFIG_NR_SIBLINGS?
On Tue, May 13, 2003 at 11:31:10PM +0200, Helge Hafting wrote:
> I don't know this code well, I'm just guessing the rigth way
> to make it compile. I don't know what's the "clean" way
> to do #if/#ifdefs either - I could probably do better if I knew.
> The problem was that CONFIG_SHARE_RUNQUEUE gets set even with
> configs where it doesn't make sense, (i.e. uniprocessor without HT)
> so I guessed it was some sort of misunderstanding about
> how #ifdef works. I hope whoever wrote that code will
> take a look and either say "yes - that's what I meant"
> or fix it in a better way.
Your fix was correct (the alternative is some rearrangment of those
#defines) and I carried it out with some additional #ifdef -> #if
conversions to cover the rest of the cases visible in my config and
sent it to akpm in another patch.
-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-05-13 21:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-13 5:55 2.5.69-mm4 Andrew Morton
2003-05-13 7:02 ` 2.5.69-mm4 Alexander Hoogerhuis
2003-05-13 7:11 ` 2.5.69-mm4 Andrew Morton
2003-05-13 8:00 ` 2.5.69-mm4 Alexander Hoogerhuis
2003-05-13 8:55 ` 2.5.69-mm4 Helge Hafting
2003-05-13 9:04 ` 2.5.69-mm4 Andrew Morton
2003-05-13 14:05 ` [PATCH] Re: 2.5.69-mm4 undefined active_load_balance Helge Hafting
2003-05-13 16:27 ` Helge Hafting
2003-05-13 16:40 ` Helge Hafting
2003-05-13 19:38 ` William Lee Irwin III
2003-05-13 21:31 ` Helge Hafting
2003-05-13 21:35 ` William Lee Irwin III [this message]
2003-05-13 11:04 ` 2.5.69-mm4 Alexander Hoogerhuis
2003-05-13 12:43 ` 2.5.69-mm4 Ed Tomlinson
2003-05-13 20:10 ` 2.5.69-mm4 Andrew Morton
2003-05-13 17:08 ` 2.5.69-mm4 smp crash, seems fs/vm related Helge Hafting
2003-05-13 20:17 ` 2.5.69-mm4 William Lee Irwin III
2003-05-13 20:25 ` 2.5.69-mm4 William Lee Irwin III
2003-05-14 0:15 ` 2.5.69-mm4 William Lee Irwin III
2003-05-14 0:46 ` 2.5.69-mm4 David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030513213527.GV8978@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@digeo.com \
--cc=alexh@ihatent.com \
--cc=helgehaf@aitel.hist.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox