From: Andrew Morton <akpm@digeo.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.67-mm3
Date: Mon, 14 Apr 2003 21:31:14 -0700 [thread overview]
Message-ID: <20030414213114.37dc7879.akpm@digeo.com> (raw)
In-Reply-To: <20030415041759.GA12487@holomorphy.com>
William Lee Irwin III <wli@holomorphy.com> wrote:
>
> + for (; addr < (unsigned long)uaddr + size && !ret; addr += PAGE_SIZE)
> + ret = __put_user(0, (char *)max(addr, (unsigned long)uaddr));
This hurts my brain. If anything, it should be formulated as a do-while loop.
But I'm not sure we should really bother, because relatively large amounts of
stuff is broken for PAGE_SIZE != PAGE_CACHE_SIZE anyway. tmpfs comes to
mind...
If page clustering needs to redo this code (and I assume it does) then that
would be an argument in favour.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-04-15 4:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-14 8:53 2.5.67-mm3 Andrew Morton
2003-04-14 11:03 ` 2.5.67-mm3 Bill Huey
2003-04-14 15:13 ` 2.5.67-mm3 Rudmer van Dijk
2003-04-15 1:03 ` 2.5.67-mm3 Bill Huey
2003-04-15 1:13 ` 2.5.67-mm3 Andrew Morton
2003-04-15 1:34 ` 2.5.67-mm3 Bill Huey
2003-04-15 9:38 ` 2.5.67-mm3 Rudmer van Dijk
2003-04-15 2:00 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 4:17 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 4:31 ` Andrew Morton [this message]
2003-04-15 4:39 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 4:55 ` 2.5.67-mm3 Andrew Morton
2003-04-15 5:15 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 5:35 ` 2.5.67-mm3 Andrew Morton
2003-04-15 6:09 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 6:10 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 5:52 ` 2.5.67-mm3 Antonio Vargas
2003-04-15 5:52 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 15:09 ` 2.5.67-mm3 Antonio Vargas
2003-04-16 2:21 ` 2.5.67-mm3 William Lee Irwin III
2003-04-16 2:40 ` 2.5.67-mm3 William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030414213114.37dc7879.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox