* Re: 2.5.67-mm2
2003-04-13 1:08 2.5.67-mm2 Andrew Morton
@ 2003-04-13 1:55 ` Felipe Alfaro Solana
2003-04-13 3:03 ` 2.5.67-mm2 Jeremy Hall
` (2 more replies)
2003-04-13 13:12 ` 2.5.67-mm2 Ingo Oeser
2003-04-14 17:48 ` 2.5.67-mm2 Joel Becker
2 siblings, 3 replies; 20+ messages in thread
From: Felipe Alfaro Solana @ 2003-04-13 1:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML, linux-mm
On Sun, 2003-04-13 at 03:08, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.67/2.5.67-mm2/
>
> . Lots of misc saved-up things.
>
> . I've changed the 32-bit dev_t patch to provide a 12:20 split rather than
> 16:16. This patch is starting to drag a bit and unless someone stops me I
> might just go submit the thing.
Any patches for CardBus/PCMCIA support? It's broken for me since
2.5.66-mm2 (it works with 2.5.66-mm1) probably due to PCI changes or the
new PCMCIA state machine: if I boot my machine with my 3Com CardBus NIC
plugged in, the kernel deadlocks while checking the sockets, but it
works when booting with the card unplugged, and then plugging it back
once the system is stable (for example, init 1).
I have written to Russell King, but had no response from him. Maybe he
is too busy. I'm stuck at 2.5.66-mm1 on my laptop.
--
Please AVOID sending me WORD, EXCEL or POWERPOINT attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html
Linux Registered User #287198
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: 2.5.67-mm2
2003-04-13 1:55 ` 2.5.67-mm2 Felipe Alfaro Solana
@ 2003-04-13 3:03 ` Jeremy Hall
2003-04-13 3:10 ` 2.5.67-mm2 Andrew Morton
2003-04-13 3:14 ` 2.5.67-mm2 William Lee Irwin III
2003-04-13 3:17 ` 2.5.67-mm2 Valdis.Kletnieks
2003-04-13 8:11 ` 2.5.67-mm2 Russell King
2 siblings, 2 replies; 20+ messages in thread
From: Jeremy Hall @ 2003-04-13 3:03 UTC (permalink / raw)
To: Felipe Alfaro Solana; +Cc: Andrew Morton, LKML, linux-mm
I dunno about that, but mm2 locks in the boot process and doesn't display
anything to me through gdb even though it is supposed to. I have gdb
console=gdb but that doesn't make the messages flow.
_J
In the new year, Felipe Alfaro Solana wrote:
> On Sun, 2003-04-13 at 03:08, Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.67/2.5.67-mm2/
> >
> > . Lots of misc saved-up things.
> >
> > . I've changed the 32-bit dev_t patch to provide a 12:20 split rather than
> > 16:16. This patch is starting to drag a bit and unless someone stops me I
> > might just go submit the thing.
>
> Any patches for CardBus/PCMCIA support? It's broken for me since
> 2.5.66-mm2 (it works with 2.5.66-mm1) probably due to PCI changes or the
> new PCMCIA state machine: if I boot my machine with my 3Com CardBus NIC
> plugged in, the kernel deadlocks while checking the sockets, but it
> works when booting with the card unplugged, and then plugging it back
> once the system is stable (for example, init 1).
>
> I have written to Russell King, but had no response from him. Maybe he
> is too busy. I'm stuck at 2.5.66-mm1 on my laptop.
>
> --
> Please AVOID sending me WORD, EXCEL or POWERPOINT attachments.
> See http://www.fsf.org/philosophy/no-word-attachments.html
> Linux Registered User #287198
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 3:03 ` 2.5.67-mm2 Jeremy Hall
@ 2003-04-13 3:10 ` Andrew Morton
2003-04-13 3:54 ` 2.5.67-mm2 Jeremy Hall
2003-04-13 3:14 ` 2.5.67-mm2 William Lee Irwin III
1 sibling, 1 reply; 20+ messages in thread
From: Andrew Morton @ 2003-04-13 3:10 UTC (permalink / raw)
To: Jeremy Hall; +Cc: felipe_alfaro, linux-kernel, linux-mm
Jeremy Hall <jhall@maoz.com> wrote:
>
> I dunno about that, but mm2 locks in the boot process and doesn't display
> anything to me through gdb even though it is supposed to. I have gdb
> console=gdb but that doesn't make the messages flow.
>
You want "gdb console=gdb". It changed.
What CPU type?
Try just 2.5.67 plus
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.67/2.5.67-mm2/broken-out/linus.patch
try disabling kgdb in config.
etcetera.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 3:10 ` 2.5.67-mm2 Andrew Morton
@ 2003-04-13 3:54 ` Jeremy Hall
2003-04-13 4:22 ` 2.5.67-mm2 Jeremy Hall
0 siblings, 1 reply; 20+ messages in thread
From: Jeremy Hall @ 2003-04-13 3:54 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jeremy Hall, felipe_alfaro, linux-kernel, linux-mm
mm1 worked.
to be clear, my append line looks like
append="gdb console=gdb pci=biosirq" and maybe some other stuff on there
to get my machine to boot in single processor mode, I have to add nosmp
and acpi=off
if I don't add acpi=off I get apic errors on my cpus, as well as if I say
noapic like the boot process says to, it says
amd errata #22 may be present. in the event of instability boot with the
noapic option
dual athlon 1900 palamino's on a tyan 2462ung
_J
In the new year, Andrew Morton wrote:
> Jeremy Hall <jhall@maoz.com> wrote:
> >
> > I dunno about that, but mm2 locks in the boot process and doesn't display
> > anything to me through gdb even though it is supposed to. I have gdb
> > console=gdb but that doesn't make the messages flow.
> >
>
> You want "gdb console=gdb". It changed.
>
> What CPU type?
>
> Try just 2.5.67 plus
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.67/2.5.67-mm2/broken-out/linus.patch
>
> try disabling kgdb in config.
>
> etcetera.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 3:54 ` 2.5.67-mm2 Jeremy Hall
@ 2003-04-13 4:22 ` Jeremy Hall
2003-04-13 4:32 ` 2.5.67-mm2 Andrew Morton
0 siblings, 1 reply; 20+ messages in thread
From: Jeremy Hall @ 2003-04-13 4:22 UTC (permalink / raw)
To: Jeremy Hall; +Cc: Andrew Morton, felipe_alfaro, linux-kernel, linux-mm
ah, here we go
BUG(); line 907 of mm/slab.c
name == "size-32"
in_interrupt() is an undefined symbol in this context, so I don't know
whether we are in interrupt context or not, if indeed that is what this
is
no symbol BYTES_PER_WORD, but size == 32
MAX_OBJ_ORDER and PAGE_SIZE are unknown symbols in this context
dtor appears to be 0, and it looks like it should be set to something
offset == 0 and it looks like it should be < 0 or > size
in kmem_cache_create from kmem_cache_sizes_init at mm/slab.c:616
_J
In the new year, Jeremy Hall wrote:
> mm1 worked.
>
> to be clear, my append line looks like
>
> append="gdb console=gdb pci=biosirq" and maybe some other stuff on there
>
> to get my machine to boot in single processor mode, I have to add nosmp
> and acpi=off
>
> if I don't add acpi=off I get apic errors on my cpus, as well as if I say
> noapic like the boot process says to, it says
>
> amd errata #22 may be present. in the event of instability boot with the
> noapic option
>
> dual athlon 1900 palamino's on a tyan 2462ung
>
> _J
>
> In the new year, Andrew Morton wrote:
> > Jeremy Hall <jhall@maoz.com> wrote:
> > >
> > > I dunno about that, but mm2 locks in the boot process and doesn't display
> > > anything to me through gdb even though it is supposed to. I have gdb
> > > console=gdb but that doesn't make the messages flow.
> > >
> >
> > You want "gdb console=gdb". It changed.
> >
> > What CPU type?
> >
> > Try just 2.5.67 plus
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.67/2.5.67-mm2/broken-out/linus.patch
> >
> > try disabling kgdb in config.
> >
> > etcetera.
> >
> > --
> > To unsubscribe, send a message with 'unsubscribe linux-mm' in
> > the body to majordomo@kvack.org. For more info on Linux MM,
> > see: http://www.linux-mm.org/ .
> > Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
> >
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 4:22 ` 2.5.67-mm2 Jeremy Hall
@ 2003-04-13 4:32 ` Andrew Morton
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Morton @ 2003-04-13 4:32 UTC (permalink / raw)
To: Jeremy Hall; +Cc: felipe_alfaro, linux-kernel, linux-mm
Jeremy Hall <jhall@maoz.com> wrote:
>
> ah, here we go
>
> BUG(); line 907 of mm/slab.c
>
Yup, it looks like the lockmeter patch has borked the preempt_count when
CONFIG_LOCKMETER=n. Sorry, I didn't test it with preempt enabled.
I'll fix that up. Meanwhile you can revert the lockmeter patch or disable
preemption.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 3:03 ` 2.5.67-mm2 Jeremy Hall
2003-04-13 3:10 ` 2.5.67-mm2 Andrew Morton
@ 2003-04-13 3:14 ` William Lee Irwin III
2003-04-13 3:50 ` 2.5.67-mm2 Jeremy Hall
1 sibling, 1 reply; 20+ messages in thread
From: William Lee Irwin III @ 2003-04-13 3:14 UTC (permalink / raw)
To: Jeremy Hall; +Cc: Felipe Alfaro Solana, Andrew Morton, LKML, linux-mm
On Sat, Apr 12, 2003 at 11:03:46PM -0400, Jeremy Hall wrote:
> I dunno about that, but mm2 locks in the boot process and doesn't display
> anything to me through gdb even though it is supposed to. I have gdb
> console=gdb but that doesn't make the messages flow.
An early printk patch (any of the several going around) may give you an
idea of where it's barfing.
-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 3:14 ` 2.5.67-mm2 William Lee Irwin III
@ 2003-04-13 3:50 ` Jeremy Hall
2003-04-13 4:42 ` 2.5.67-mm2 Andrew Morton
0 siblings, 1 reply; 20+ messages in thread
From: Jeremy Hall @ 2003-04-13 3:50 UTC (permalink / raw)
To: William Lee Irwin III
Cc: Jeremy Hall, Felipe Alfaro Solana, Andrew Morton, LKML, linux-mm
well I guess I could step through one thing at a time, n, because I DO get
an initial trap it comes as soon as cpus are brought up
but that would take a long time and I'm sure there's LOTS of code.
_J
In the new year, William Lee Irwin III wrote:
> On Sat, Apr 12, 2003 at 11:03:46PM -0400, Jeremy Hall wrote:
> > I dunno about that, but mm2 locks in the boot process and doesn't display
> > anything to me through gdb even though it is supposed to. I have gdb
> > console=gdb but that doesn't make the messages flow.
>
> An early printk patch (any of the several going around) may give you an
> idea of where it's barfing.
>
>
> -- wli
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 3:50 ` 2.5.67-mm2 Jeremy Hall
@ 2003-04-13 4:42 ` Andrew Morton
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Morton @ 2003-04-13 4:42 UTC (permalink / raw)
To: Jeremy Hall
Cc: wli, felipe_alfaro, linux-kernel, linux-mm, Joshua Kwan, Shane Shrybman
This should fix it up.
include/linux/spinlock.h | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff -puN include/linux/spinlock.h~lockmeter-fixes include/linux/spinlock.h
--- 25/include/linux/spinlock.h~lockmeter-fixes 2003-04-12 21:35:49.000000000 -0700
+++ 25-akpm/include/linux/spinlock.h 2003-04-12 21:35:57.000000000 -0700
@@ -328,20 +328,20 @@ do { \
#define spin_unlock_irqrestore(lock, flags) \
do { \
- spin_unlock(lock); \
+ _raw_spin_unlock(lock); \
local_irq_restore(flags); \
preempt_enable(); \
} while (0)
#define _raw_spin_unlock_irqrestore(lock, flags) \
do { \
- spin_unlock(lock); \
+ _raw_spin_unlock(lock); \
local_irq_restore(flags); \
} while (0)
#define spin_unlock_irq(lock) \
do { \
- spin_unlock(lock); \
+ _raw_spin_unlock(lock); \
local_irq_enable(); \
preempt_enable(); \
} while (0)
@@ -355,14 +355,14 @@ do { \
#define read_unlock_irqrestore(lock, flags) \
do { \
- read_unlock(lock); \
+ _raw_read_unlock(lock); \
local_irq_restore(flags); \
preempt_enable(); \
} while (0)
#define read_unlock_irq(lock) \
do { \
- read_unlock(lock); \
+ _raw_read_unlock(lock); \
local_irq_enable(); \
preempt_enable(); \
} while (0)
@@ -376,14 +376,14 @@ do { \
#define write_unlock_irqrestore(lock, flags) \
do { \
- write_unlock(lock); \
+ _raw_write_unlock(lock); \
local_irq_restore(flags); \
preempt_enable(); \
} while (0)
#define write_unlock_irq(lock) \
do { \
- write_unlock(lock); \
+ _raw_write_unlock(lock); \
local_irq_enable(); \
preempt_enable(); \
} while (0)
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 1:55 ` 2.5.67-mm2 Felipe Alfaro Solana
2003-04-13 3:03 ` 2.5.67-mm2 Jeremy Hall
@ 2003-04-13 3:17 ` Valdis.Kletnieks
2003-04-13 11:15 ` 2.5.67-mm2 Felipe Alfaro Solana
2003-04-13 8:11 ` 2.5.67-mm2 Russell King
2 siblings, 1 reply; 20+ messages in thread
From: Valdis.Kletnieks @ 2003-04-13 3:17 UTC (permalink / raw)
To: Felipe Alfaro Solana; +Cc: Andrew Morton, LKML, linux-mm
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
On Sun, 13 Apr 2003 03:55:29 +0200, Felipe Alfaro Solana said:
> Any patches for CardBus/PCMCIA support? It's broken for me since
> 2.5.66-mm2 (it works with 2.5.66-mm1) probably due to PCI changes or the
> new PCMCIA state machine: if I boot my machine with my 3Com CardBus NIC
> plugged in, the kernel deadlocks while checking the sockets, but it
> works when booting with the card unplugged, and then plugging it back
> once the system is stable (for example, init 1).
Also seeing this with a Xircom card under vanilla 2.5.67.
lspci reports this card as:
03:00.0 Ethernet controller: Xircom Cardbus Ethernet 10/100 (rev 03)
03:00.1 Serial controller: Xircom Cardbus Ethernet + 56k Modem (rev 03)
Russel King posted an analysis back on April 1, which indicated he knew
about the problem, understood it, and was working on it.
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 3:17 ` 2.5.67-mm2 Valdis.Kletnieks
@ 2003-04-13 11:15 ` Felipe Alfaro Solana
0 siblings, 0 replies; 20+ messages in thread
From: Felipe Alfaro Solana @ 2003-04-13 11:15 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: Andrew Morton, LKML, linux-mm
On Sun, 2003-04-13 at 05:17, Valdis.Kletnieks@vt.edu wrote:
> On Sun, 13 Apr 2003 03:55:29 +0200, Felipe Alfaro Solana said:
>
> > Any patches for CardBus/PCMCIA support? It's broken for me since
> > 2.5.66-mm2 (it works with 2.5.66-mm1) probably due to PCI changes or the
> > new PCMCIA state machine: if I boot my machine with my 3Com CardBus NIC
> > plugged in, the kernel deadlocks while checking the sockets, but it
> > works when booting with the card unplugged, and then plugging it back
> > once the system is stable (for example, init 1).
>
> Also seeing this with a Xircom card under vanilla 2.5.67.
>
> lspci reports this card as:
>
> 03:00.0 Ethernet controller: Xircom Cardbus Ethernet 10/100 (rev 03)
> 03:00.1 Serial controller: Xircom Cardbus Ethernet + 56k Modem (rev 03)
>
> Russel King posted an analysis back on April 1, which indicated he knew
> about the problem, understood it, and was working on it.
Yeah! I know, but I wrote him and didn't get a response, so I'm a little
bit worried. I assume he'll be too busy.
--
Please AVOID sending me WORD, EXCEL or POWERPOINT attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html
Linux Registered User #287198
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 1:55 ` 2.5.67-mm2 Felipe Alfaro Solana
2003-04-13 3:03 ` 2.5.67-mm2 Jeremy Hall
2003-04-13 3:17 ` 2.5.67-mm2 Valdis.Kletnieks
@ 2003-04-13 8:11 ` Russell King
2 siblings, 0 replies; 20+ messages in thread
From: Russell King @ 2003-04-13 8:11 UTC (permalink / raw)
To: Felipe Alfaro Solana; +Cc: Andrew Morton, LKML, linux-mm
On Sun, Apr 13, 2003 at 03:55:29AM +0200, Felipe Alfaro Solana wrote:
> I have written to Russell King, but had no response from him. Maybe he
> is too busy. I'm stuck at 2.5.66-mm1 on my laptop.
I've been on holiday for the past week, and am currently playing the
catch-up game. People will have to wait a while longer until I can
get back to PCMCIA - I also look after the ARM kernel, which is also
requiring my attention at present.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 1:08 2.5.67-mm2 Andrew Morton
2003-04-13 1:55 ` 2.5.67-mm2 Felipe Alfaro Solana
@ 2003-04-13 13:12 ` Ingo Oeser
2003-04-13 14:54 ` 2.5.67-mm2 Arjan van de Ven
2003-04-14 17:48 ` 2.5.67-mm2 Joel Becker
2 siblings, 1 reply; 20+ messages in thread
From: Ingo Oeser @ 2003-04-13 13:12 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mm
Hi Andrew,
hi lists readers,
On Sat, Apr 12, 2003 at 06:08:52PM -0700, Andrew Morton wrote:
> +gfp_repeat.patch
>
> Implement __GFP_REPEAT: so we can consolidate lots of alloc-with-retry code.
What about reworking the semantics of kmalloc()?
Many users of kmalloc get the flags and size reversed (major
source of hard to find bugs), so wouldn't it be simpler to have:
__kmalloc() /* The old kmalloc()*/
kmalloc() /* kmalloc(, GFP_KERNEL) */
kmalloc_user() /* kmalloc(, GFP_USER) */
kmalloc_dma() /* kmalloc(, GFP_KERNEL | GFP_DMA) */
kmalloc_dma_repeat() /* kmalloc(, GFP_KERNEL | GFP_DMA | __GFP_REPEAT) */
kmalloc_repeat() /* kmalloc(, GFP_KERNEL | __GFP_REPEAT) */
kmalloc_atomic() /* kmalloc(, GFP_ATOMIC) */
kmalloc_atomic_dma() /* kmalloc(, GFP_ATOMIC | GFP_DMA) */
an so on? These functions will of course just be static inline
wrappers for __kmalloc().
These functions above would just take a size and not confuse
programmers anymore (as prototypes with compatible arguments
usally do).
If it's just a matter of "nobody had the time do do it, yet",
than this is doable, if only slowly.
If this is considered nonsense, then I will shut-up.
What do you think?
Regards
Ingo Oeser
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 13:12 ` 2.5.67-mm2 Ingo Oeser
@ 2003-04-13 14:54 ` Arjan van de Ven
2003-04-14 6:24 ` 2.5.67-mm2 Denis Vlasenko
0 siblings, 1 reply; 20+ messages in thread
From: Arjan van de Ven @ 2003-04-13 14:54 UTC (permalink / raw)
To: Ingo Oeser; +Cc: Andrew Morton, linux-kernel, linux-mm
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
On Sun, 2003-04-13 at 15:12, Ingo Oeser wrote:
> Hi Andrew,
> hi lists readers,
>
> On Sat, Apr 12, 2003 at 06:08:52PM -0700, Andrew Morton wrote:
> > +gfp_repeat.patch
> >
> > Implement __GFP_REPEAT: so we can consolidate lots of alloc-with-retry code.
>
> What about reworking the semantics of kmalloc()?
>
> Many users of kmalloc get the flags and size reversed (major
> source of hard to find bugs), so wouldn't it be simpler to have:
that in itself is easy to find btw; just give every GFP_* an extra
__GFP_REQUIRED bit and then check inside kmalloc for that bit (MSB?) to
be set.....
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 14:54 ` 2.5.67-mm2 Arjan van de Ven
@ 2003-04-14 6:24 ` Denis Vlasenko
2003-04-14 8:49 ` 2.5.67-mm2 Arjan van de Ven
0 siblings, 1 reply; 20+ messages in thread
From: Denis Vlasenko @ 2003-04-14 6:24 UTC (permalink / raw)
To: arjanv, Ingo Oeser; +Cc: Andrew Morton, linux-kernel, linux-mm
On 13 April 2003 17:54, Arjan van de Ven wrote:
> On Sun, 2003-04-13 at 15:12, Ingo Oeser wrote:
> > Hi Andrew,
> > hi lists readers,
> >
> > On Sat, Apr 12, 2003 at 06:08:52PM -0700, Andrew Morton wrote:
> > > +gfp_repeat.patch
> > >
> > > Implement __GFP_REPEAT: so we can consolidate lots of
> > > alloc-with-retry code.
> >
> > What about reworking the semantics of kmalloc()?
> >
> > Many users of kmalloc get the flags and size reversed (major
> > source of hard to find bugs), so wouldn't it be simpler to have:
>
> that in itself is easy to find btw; just give every GFP_* an extra
> __GFP_REQUIRED bit and then check inside kmalloc for that bit (MSB?)
> to be set.....
This will incur runtime penalty
--
vda
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-14 6:24 ` 2.5.67-mm2 Denis Vlasenko
@ 2003-04-14 8:49 ` Arjan van de Ven
0 siblings, 0 replies; 20+ messages in thread
From: Arjan van de Ven @ 2003-04-14 8:49 UTC (permalink / raw)
To: Denis Vlasenko; +Cc: arjanv, Ingo Oeser, Andrew Morton, linux-kernel, linux-mm
On Mon, Apr 14, 2003 at 09:24:26AM +0300, Denis Vlasenko wrote:
> >
> > that in itself is easy to find btw; just give every GFP_* an extra
> > __GFP_REQUIRED bit and then check inside kmalloc for that bit (MSB?)
> > to be set.....
>
> This will incur runtime penalty
but only for CONFIG_DEBUG_KMALLOC or whatever
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-13 1:08 2.5.67-mm2 Andrew Morton
2003-04-13 1:55 ` 2.5.67-mm2 Felipe Alfaro Solana
2003-04-13 13:12 ` 2.5.67-mm2 Ingo Oeser
@ 2003-04-14 17:48 ` Joel Becker
2003-04-14 21:31 ` 2.5.67-mm2 Andrew Morton
2 siblings, 1 reply; 20+ messages in thread
From: Joel Becker @ 2003-04-14 17:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mm
On Sat, Apr 12, 2003 at 06:08:52PM -0700, Andrew Morton wrote:
> . I've changed the 32-bit dev_t patch to provide a 12:20 split rather than
> 16:16. This patch is starting to drag a bit and unless someone stops me I
> might just go submit the thing.
Cool, but before you go off and push, maybe kick the appropriate
folks about making the 32/64 decision?
Joel
--
"When choosing between two evils, I always like to try the one
I've never tried before."
- Mae West
Joel Becker
Senior Member of Technical Staff
Oracle Corporation
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: 2.5.67-mm2
2003-04-14 17:48 ` 2.5.67-mm2 Joel Becker
@ 2003-04-14 21:31 ` Andrew Morton
2003-04-14 21:34 ` 2.5.67-mm2 Randy.Dunlap
0 siblings, 1 reply; 20+ messages in thread
From: Andrew Morton @ 2003-04-14 21:31 UTC (permalink / raw)
To: Joel Becker; +Cc: linux-kernel, linux-mm
Joel Becker <Joel.Becker@oracle.com> wrote:
>
> On Sat, Apr 12, 2003 at 06:08:52PM -0700, Andrew Morton wrote:
> > . I've changed the 32-bit dev_t patch to provide a 12:20 split rather than
> > 16:16. This patch is starting to drag a bit and unless someone stops me I
> > might just go submit the thing.
>
> Cool, but before you go off and push, maybe kick the appropriate
> folks about making the 32/64 decision?
>
It'll be 32+32. I was just trolling.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: 2.5.67-mm2
2003-04-14 21:31 ` 2.5.67-mm2 Andrew Morton
@ 2003-04-14 21:34 ` Randy.Dunlap
0 siblings, 0 replies; 20+ messages in thread
From: Randy.Dunlap @ 2003-04-14 21:34 UTC (permalink / raw)
To: Andrew Morton; +Cc: Joel.Becker, linux-kernel, linux-mm
On Mon, 14 Apr 2003 14:31:41 -0700 Andrew Morton <akpm@digeo.com> wrote:
| Joel Becker <Joel.Becker@oracle.com> wrote:
| >
| > On Sat, Apr 12, 2003 at 06:08:52PM -0700, Andrew Morton wrote:
| > > . I've changed the 32-bit dev_t patch to provide a 12:20 split rather than
| > > 16:16. This patch is starting to drag a bit and unless someone stops me I
| > > might just go submit the thing.
| >
| > Cool, but before you go off and push, maybe kick the appropriate
| > folks about making the 32/64 decision?
| >
|
| It'll be 32+32. I was just trolling.
Good. and good.
--
~Randy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 20+ messages in thread