From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 3 Apr 2003 12:06:11 -0800 From: Andrew Morton Subject: Re: [PATCH 2.5.66-mm2] Fix page_convert_anon locking issues Message-Id: <20030403120611.6691399e.akpm@digeo.com> In-Reply-To: <92070000.1049381395@[10.1.1.5]> References: <8910000.1049303582@baldur.austin.ibm.com> <20030402132939.647c74a6.akpm@digeo.com> <80300000.1049320593@baldur.austin.ibm.com> <20030402150903.21765844.akpm@digeo.com> <102170000.1049325787@baldur.austin.ibm.com> <20030402153845.0770ef54.akpm@digeo.com> <110950000.1049326945@baldur.austin.ibm.com> <20030402155220.651a1005.akpm@digeo.com> <116640000.1049327888@baldur.austin.ibm.com> <92070000.1049381395@[10.1.1.5]> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Dave McCracken Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Dave McCracken wrote: > > > --On Wednesday, April 02, 2003 17:58:08 -0600 Dave McCracken > wrote: > > > It's looking more and more like we should use your other suggestion. It's > > definitely simpler if we can make it failsafe. I'll code it up tomorrow. > > I thought of a big hole in the simpler scheme you suggested. It occurred > to me that try_to_unmap will fail. It will see the PageAnon flag so it'll > just walk the pte_chain and assume it doesn't have to walk the vmas. This > will leave the page with some stranded mappings. Actually > page_convert_anon will then finish, and we'll have a page where > try_to_unmap claims it has succeeded but still has mappings. > page_referenced() has the same problem, so refill_inactive_zone() will need to lock pages too. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org