From: Andrew Morton <akpm@digeo.com>
To: Dave McCracken <dmccr@us.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.66-mm2] Fix page_convert_anon locking issues
Date: Thu, 3 Apr 2003 12:00:39 -0800 [thread overview]
Message-ID: <20030403120039.5c95813c.akpm@digeo.com> (raw)
In-Reply-To: <92070000.1049381395@[10.1.1.5]>
Dave McCracken <dmccr@us.ibm.com> wrote:
>
>
> --On Wednesday, April 02, 2003 17:58:08 -0600 Dave McCracken
> <dmccr@us.ibm.com> wrote:
>
> > It's looking more and more like we should use your other suggestion. It's
> > definitely simpler if we can make it failsafe. I'll code it up tomorrow.
>
> I thought of a big hole in the simpler scheme you suggested. It occurred
> to me that try_to_unmap will fail. It will see the PageAnon flag so it'll
> just walk the pte_chain and assume it doesn't have to walk the vmas. This
> will leave the page with some stranded mappings. Actually
> page_convert_anon will then finish, and we'll have a page where
> try_to_unmap claims it has succeeded but still has mappings.
>
Lock the page, and page reclaim will not go near it. It needs to be locked
across page_convert_anon() anyway, to protect ->mapping.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2003-04-03 20:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-02 17:13 Dave McCracken
2003-04-02 21:29 ` Andrew Morton
2003-04-02 21:56 ` Dave McCracken
2003-04-02 23:09 ` Andrew Morton
2003-04-02 23:23 ` Dave McCracken
2003-04-02 23:38 ` Andrew Morton
2003-04-02 23:42 ` Dave McCracken
2003-04-02 23:52 ` Andrew Morton
2003-04-02 23:58 ` Dave McCracken
2003-04-03 14:49 ` Dave McCracken
2003-04-03 15:38 ` Hugh Dickins
2003-04-03 16:00 ` Dave McCracken
2003-04-03 16:33 ` Hugh Dickins
2003-04-03 16:39 ` Dave McCracken
2003-04-03 20:00 ` Andrew Morton [this message]
2003-04-03 20:06 ` Andrew Morton
2003-04-03 20:56 ` Andrew Morton
2003-04-03 21:01 ` Dave McCracken
2003-04-02 23:59 ` Hugh Dickins
2003-04-03 0:06 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030403120039.5c95813c.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=dmccr@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox