From: Andrew Morton <akpm@digeo.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] anobjrmap 2/6 mapping
Date: Thu, 20 Mar 2003 22:48:32 -0800 [thread overview]
Message-ID: <20030320224832.0334712d.akpm@digeo.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0303202312560.2743-100000@localhost.localdomain>
Hugh Dickins <hugh@veritas.com> wrote:
>
> It is likely that I've screwed up on the "Morton pages", those
> ext3 journal pages locked at truncate time which then turn into
> fish with wings: please check them out, I never manage to wrap
> my head around them. Certainly don't want a page using private
> for both bufferheads and swp_entry_t.
It goes BUG in try_to_free_buffers().
We really should fix this up for other reasons, probably by making ext3's
per-page truncate operations wait on commit, and be more aggressive about
pulling the page's buffers off the transaction at truncate time.
The same thing _could_ happen with other filesystems; not too sure about
that.
Still. I suggest you look at freeing up page->list from anon/swapcache
pages. It really doesn't do much.
Meanwhile, I backed out that bit - I don't actually see where the failure is
anyway. The page is page_mapped(), !PageAnon and ->mapping == NULL.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2003-03-21 6:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-20 23:12 [PATCH] anobjrmap 1/6 rmap.h Hugh Dickins
2003-03-20 23:14 ` [PATCH] anobjrmap 2/6 mapping Hugh Dickins
2003-03-21 6:48 ` Andrew Morton [this message]
2003-03-24 19:38 ` Stephen C. Tweedie
2003-03-24 22:12 ` Andrew Morton
2003-03-20 23:15 ` [PATCH] anobjrmap 3/6 unchained Hugh Dickins
2003-03-20 23:20 ` William Lee Irwin III
2003-03-20 23:15 ` [PATCH] anobjrmap 4/6 anonmm Hugh Dickins
2003-03-20 23:16 ` [PATCH] anobjrmap 5/6 rechained Hugh Dickins
2003-03-20 23:17 ` [PATCH] anobjrmap 6/6 arches Hugh Dickins
2003-03-21 6:48 ` [PATCH] anobjrmap 1/6 rmap.h Andrew Morton
2003-03-21 7:07 ` William Lee Irwin III
2003-03-21 7:15 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030320224832.0334712d.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox