From: Andrew Morton <akpm@digeo.com>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: haveblue@us.ibm.com, bcrl@redhat.com, linux-mm@kvack.org
Subject: Re: [PATCH] remove __pte_offset
Date: Tue, 4 Mar 2003 18:04:17 -0800 [thread overview]
Message-ID: <20030304180417.252b2fde.akpm@digeo.com> (raw)
In-Reply-To: <635420000.1046828613@flay>
"Martin J. Bligh" <mbligh@aracnet.com> wrote:
>
> >> While we're on the subject, does anyone else find the p*_offset
> >> functions confusing?
> >
> > How about sticking nice comments over them, rather than rampant renamings?
>
> Would be nice if you could know what the thing did by just looking at
> the caller rather than the definition.
>
> Remaning everything is probably bad, but the renames of __pgd_offset
> et al seem eminently sane to me, the fact that pgd_offset and __pgd_offset
> return different types seems like horrible confusion for no real reason
> or benefit, especially when pgd_index already exists ...
>
Oh I agree that pte_index is a fine name for it. But not commenting the damn
things is a bug. Sigh.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2003-03-05 2:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-04 23:00 [PATCH] remove __pgd_offset Dave Hansen
2003-03-04 23:02 ` [PATCH] remove __pmd_offset Dave Hansen
2003-03-04 23:03 ` [PATCH] remove __pte_offset Dave Hansen
2003-03-04 23:10 ` Benjamin LaHaise
2003-03-04 23:09 ` Martin J. Bligh
2003-03-04 23:22 ` Andrew Morton
2003-03-04 23:25 ` Dave Hansen
2003-03-04 23:26 ` Benjamin LaHaise
2003-03-04 23:29 ` Martin J. Bligh
2003-03-04 23:57 ` Dave Hansen
2003-03-05 0:01 ` Andrew Morton
2003-03-05 1:43 ` Martin J. Bligh
2003-03-05 2:04 ` Andrew Morton [this message]
2003-03-05 3:32 ` Randy.Dunlap
2003-03-04 23:16 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030304180417.252b2fde.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=bcrl@redhat.com \
--cc=haveblue@us.ibm.com \
--cc=linux-mm@kvack.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox