From: Andrew Morton <akpm@digeo.com>
To: Dave McCracken <dmccr@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2.5.63] Teach page_mapped about the anon flag
Date: Mon, 3 Mar 2003 13:35:39 -0800 [thread overview]
Message-ID: <20030303133539.6594e0b6.akpm@digeo.com> (raw)
In-Reply-To: <107610000.1046726685@baldur.austin.ibm.com>
Dave McCracken <dmccr@us.ibm.com> wrote:
>
>
> --On Monday, March 03, 2003 13:12:10 -0800 Andrew Morton <akpm@digeo.com>
> wrote:
>
> > It is. All callers which need to be 100% accurate are under
> > pte_chain_lock().
>
> Hmm, good point. Some places may not need perfect accuracy. Also, if it
> gives a false positive it means someone else is doing an atomic op on it,
> so it's likely to be in transition to/from true anyway.
>
> Ok, you've convinced me. Please ignore the patch. I'll hang onto it in
> case we get proved wrong at some point.
We do need a patch I think. page_mapped() is still assuming that an
all-bits-zero atomic_t corresponds to a zero-value atomic_t.
This does appear to be true for all supported architectures, but it's a bit
grubby.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2003-03-03 21:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-27 10:59 2.5.63-mm1 Andrew Morton
2003-02-27 21:22 ` Rising io_load results 2.5.63-mm1 Con Kolivas
2003-02-27 21:44 ` Andrew Morton
2003-02-27 22:01 ` Dave McCracken
2003-02-27 22:24 ` Andrew Morton
2003-03-03 21:06 ` [PATCH 2.5.63] Teach page_mapped about the anon flag Dave McCracken
2003-03-03 21:12 ` Andrew Morton
2003-03-03 21:24 ` Dave McCracken
2003-03-03 21:35 ` Andrew Morton [this message]
2003-03-03 21:52 ` Dave McCracken
2003-03-03 22:15 ` Andrew Morton
2003-03-04 18:32 ` [PATCH 2.5.63] Make objrmap mapcount non-atomic Dave McCracken
2003-02-27 23:56 ` Rising io_load results Re: 2.5.63-mm1 Con Kolivas
2003-02-28 0:06 ` Andrew Morton
2003-02-28 0:28 ` Con Kolivas
2003-02-28 7:46 ` Duncan Sands
2003-02-28 8:06 ` Andrew Morton
2003-02-28 12:48 ` Hugh Dickins
2003-02-28 15:56 ` Dave McCracken
2003-02-28 0:17 ` 2.5.63-mm1 Ed Tomlinson
2003-02-28 0:46 ` 2.5.63-mm1 Andrew Morton
2003-02-28 12:16 ` 2.5.63-mm1 steven roemen
2003-02-28 12:24 ` 2.5.63-mm1 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030303133539.6594e0b6.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=dmccr@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox