From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from digeo-nav01.digeo.com (digeo-nav01.digeo.com [192.168.1.233]) by packet.digeo.com (8.9.3+Sun/8.9.3) with SMTP id MAA20456 for ; Wed, 5 Feb 2003 12:00:46 -0800 (PST) Date: Wed, 5 Feb 2003 12:00:40 -0800 From: Andrew Morton Subject: Re: hugepage patches Message-Id: <20030205120040.3d0b8d96.akpm@digeo.com> In-Reply-To: <20030205115752.2c416ad4.akpm@digeo.com> References: <20030131151501.7273a9bf.akpm@digeo.com> <20030202025546.2a29db61.akpm@digeo.com> <20030202195908.GD29981@holomorphy.com> <20030202124943.30ea43b7.akpm@digeo.com> <20030203132929.40f0d9c0.akpm@digeo.com> <20030204055012.GD1599@holomorphy.com> <162820000.1044342992@[10.10.2.4]> <20030204131206.2b6c33fa.akpm@digeo.com> <20030205115752.2c416ad4.akpm@digeo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: ebiederm@xmission.com, mbligh@aracnet.com, wli@holomorphy.com, davem@redhat.com, rohit.seth@intel.com, davidm@napali.hpl.hp.com, anton@samba.org, linux-mm@kvack.org List-ID: Andrew Morton wrote: > > > - inode->i_sem is not taken to protect inode->i_size. > > OK, I'll fix that up. > > > - After successfully allocating a page, a test is not made to see if > > another process with the same mapping has allocated the page first. > > In this case, add_to_page_cache() in hugetlb_prefault() will return -EEXIST, > and the page which lost the race will be freed again. > > Uh, but we don't establish a pte against the page which got there first. > I'll fix that up too. Thanks. No, everything is OK isn't it? The entire operation (i_size update and allocate/add_to_page_cache()) is serialised under i_sem. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/