From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from digeo-nav01.digeo.com (digeo-nav01.digeo.com [192.168.1.233]) by packet.digeo.com (8.9.3+Sun/8.9.3) with SMTP id MAA16295 for ; Sun, 2 Feb 2003 12:49:33 -0800 (PST) Date: Sun, 2 Feb 2003 12:49:43 -0800 From: Andrew Morton Subject: Re: hugepage patches Message-Id: <20030202124943.30ea43b7.akpm@digeo.com> In-Reply-To: <20030202195908.GD29981@holomorphy.com> References: <20030131151501.7273a9bf.akpm@digeo.com> <20030202025546.2a29db61.akpm@digeo.com> <20030202195908.GD29981@holomorphy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: William Lee Irwin III Cc: davem@redhat.com, rohit.seth@intel.com, davidm@napali.hpl.hp.com, anton@samba.org, linux-mm@kvack.org List-ID: William Lee Irwin III wrote: > > On Sun, Feb 02, 2003 at 02:55:46AM -0800, Andrew Morton wrote: > > 6/4 > > hugetlbfs: fix truncate > > - Opening a hugetlbfs file O_TRUNC calls the generic vmtruncate() functions > > and nukes the kernel. > > Give S_ISREG hugetlbfs files a inode_operations, and hence a setattr > > which know how to handle these files. > > - Don't permit the user to truncate hugetlbfs files to sizes which are not > > a multiple of HPAGE_SIZE. > > - We don't support expanding in ftruncate(), so remove that code. > > erm, IIRC ftruncate() was the only way to expand the things; Expanding ftruncate would be nice, but the current way of performing the page instantiation at mmap() time seems sufficient. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/