From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E226BC83038 for ; Tue, 1 Jul 2025 14:51:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CBB56B009F; Tue, 1 Jul 2025 10:51:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57C076B00A1; Tue, 1 Jul 2025 10:51:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4445F6B00A2; Tue, 1 Jul 2025 10:51:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 309D06B009F for ; Tue, 1 Jul 2025 10:51:37 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 76868804D0 for ; Tue, 1 Jul 2025 14:51:36 +0000 (UTC) X-FDA: 83615984592.14.3AF3A4C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 11EE3100004 for ; Tue, 1 Jul 2025 14:51:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XWMIP55L; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751381494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EfoMdtoDyXREIezrPUdu2a2yagVb9vBk4JaNn3pDuBo=; b=34dYTTJwzvcX7Y5wuyDuU1A+lgfq7me2iGwJINyrb+EdkGUA/REW8xGyKFruTt/3p17M+T 428ZLHECJwrCWc11nwkZ4ei31QFlxOPAgmPdCaw33VPiwTTpXPJB9AmET5I0Zfzb6PgbzF 9OU6JFC/32yawHKDr8buEsPlIourJnc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XWMIP55L; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751381494; a=rsa-sha256; cv=none; b=Ia5vyT21cR/dw4lKqVScdyJdgQUrf+5M56UyzrFkuCsshzSClcmJ3KlXSoN+qoTX58BGym z9MFtQENy6aiNjxvx6eN2b7TRpH/cI3D7+4cPO0QyivunU27IJTDmqfUW5L+wju2KyghC/ 3QNQiAeza+a+q81mN7bSKMkf9gEVjF4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751381493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EfoMdtoDyXREIezrPUdu2a2yagVb9vBk4JaNn3pDuBo=; b=XWMIP55LbqWD4D9wb+lLQ/8nculSRBZGtnsSn4GpRYofOtJ+m/NS+OQZ9wgSvrobnaZ5zg 8jcgzcb+ZddeLqh9FreLUov2+OiByUmh8iGQWlsunNTz63ER3mbz0qViPu4Wy3mFCEMvwd iaRppCXRXTJ7myPz7RH7FpI2KW63MVM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-36AgMguTMo2ncjAAUgKU6Q-1; Tue, 01 Jul 2025 10:51:32 -0400 X-MC-Unique: 36AgMguTMo2ncjAAUgKU6Q-1 X-Mimecast-MFC-AGG-ID: 36AgMguTMo2ncjAAUgKU6Q_1751381491 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451ecc3be97so26080615e9.0 for ; Tue, 01 Jul 2025 07:51:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751381491; x=1751986291; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EfoMdtoDyXREIezrPUdu2a2yagVb9vBk4JaNn3pDuBo=; b=WIHRpG5W/cqXIyQykEWrdC97tGRS79Fu2kyz0r+Etg7G8aFPCqfIs9rt6gxaSsURFG cOL4cjBSS8YXoBCZ1gzJyxm9VQVrkhmej1P8p0e1HQK+kZAV9ul9v6WRCZpbMD4o+zOS gsM1x3f0L30IxLmAn7Ri18QXpAtf7RosoWcFS2h51chlxJD0L/QbbVVESTwjcGPPhkNQ hZeyXXenblJgL5PJ6ls15uxVKBpAjqUlgk1wMhv4iBLN7tm9D9MAVjWB8ss3ZZDo0M8b rG7yQPlqjTgxUGdVnWEyx5HUVVqKWhtDobXRPQ6Pm+unKmx+RHfxDuyDqqXm+64uClgX 1kuw== X-Forwarded-Encrypted: i=1; AJvYcCVZA/Yunu9Dul//d08/2Wao1U4VP4kxlIZ+A67cT39jYbN2bnZx7HGaev+KLE3lVl3y7JnFuJFQsA==@kvack.org X-Gm-Message-State: AOJu0Yxyd6pNNNKlWeLS74YCoq+ITntORG7SSwIGby309EbrjkfnSbja cpx8ojyM9i2d98nVFbLSL1HcuqFLSFTtF5zfmpp52GuYxaBQWgUVLQb69G4ehINbfkY/eZM9Ft2 2zX2o5anwN03z1uH62muGozk4ompQf9y927xlzzXH7Byqu7pFWUeH X-Gm-Gg: ASbGncvYoIMUJU4Hi5qD33hSnpEheLRDj8PY3criZHJkULhAoii3ieh1cDT62iMtj7X rNBrvzFHBlXCcN5NYPxij8Ba0iHC9tItk82R+TbY3vUW4fqClEfsJONh6en3e0ix997M5jaDaZw ABelCnJkm/HmSgf0yehkj63FbjOAJJleWgqmIRfw5PsAxoaIN9ye0pjckg9olc1/RVxzO3DVf4f hTN4OcBidXZoNKIot4x4KNsoSHTn/oVbAIEajafbhj0lJUIbUQpZNcNvKCkp0sFSej2U8S9kRtb wxpn/VEaArOm2cXYEnX/eXBXifhQrOwzuUcXrtNIj6og1f7vJOMohJ9Rvk93vSlemJYFNgajc5q 7cIWVWTq3rauclwLnlEGMOG8YlxPhW1Xvlrn5O/Oc0KWhdJB7dQ== X-Received: by 2002:a05:600c:19d4:b0:43d:2313:7b49 with SMTP id 5b1f17b1804b1-4539517a717mr153524515e9.12.1751381490913; Tue, 01 Jul 2025 07:51:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMux53C2I8qV2sDcGrxw/+8VvZIK9p/Asqk8P2x7vDhoU+mdYa6aqec+kf1tu5AD1aCAThtw== X-Received: by 2002:a05:600c:19d4:b0:43d:2313:7b49 with SMTP id 5b1f17b1804b1-4539517a717mr153524095e9.12.1751381490432; Tue, 01 Jul 2025 07:51:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823ad0fesm203561125e9.25.2025.07.01.07.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 07:51:29 -0700 (PDT) Message-ID: <20027e0c-f43b-4d10-a4d6-41dcc38145bd@redhat.com> Date: Tue, 1 Jul 2025 16:51:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: pagemap_scan ioctl: add PFN ZERO test cases To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250630102443.137809-1-usama.anjum@collabora.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250630102443.137809-1-usama.anjum@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qI6BYqL-dFQHhu2DKokDyQ1EYMada3WMBWNenQgnP68_1751381491 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 81ingtx3xqj66eieh1sh4cej3cewmja1 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 11EE3100004 X-Rspam-User: X-HE-Tag: 1751381493-318184 X-HE-Meta: U2FsdGVkX18IHrVZezzCIc3ptOOPpWhWMt+8/jfN3ZmfN/lerpt+mmOr6RqXu96WHtw0SUhIGUegT+X7FR8qyj5axoIt7ADfoBJ9BdA4lrVKNGZvosW2I//YrJ/yyLCVvnzB31BG7NpkvmaaIUSUhrjYRkbgiF47A3Kr/OH8Ev6fgmdgM7BI1elvDfjALjkeHVBVCfGo/B4xsk+S4ec7imFcRSBOCf6gOMbmoxUU9+cRtutQ/gD2aB3c6MfwkydbQlsrfxpay6uFfJCVo6rzZkAY4oxhDksXjA5kfFoX8350o1cYQuktMTRp/FUtcuJL0qJ2RgRTB2TzTcyBOn4ypp6UP+TAA+GDyMdYZVX8V+54YL27zNhy2rF9SkOjt9J6MmRNK0w8UWA0M+JrxvKdfgJ+IBvjyM82tEHTkzjTmCnHBG/W9ZeQC7aDhVlKKge7v2ZE0GWu6JVSI7aeZrIgnPDn2rBkg7VIhpuULfLUkwae9bvWGX6y4hT4wum52rilRwNNfimkdyf22eFEaMdsEchQxriQ6NPbTpnhem0LRHJxGkK1OMsja1YPPzq5e5trTObIGxjDvhaPbw+vbTVc7StPY8ucdoga57vtXrpXA6/VJNEbsmihlZDZJEhvzLXhyz+qolv3V4+wBOOwUe6DYgYKvu8cuXlsnlBRfriCiwGlaKai9aM0cfz5qK5cTdB+f7fV4UU0isgjIsvAjZtPuH4kfVP3EDGCF6lUsF+tv/jOhoKdcvSFa78BRriA3QhEmWwbNjKXqpZkd8jnaDgMOUZNatM6NakMGvC8fd9xsZ5+IJgMnKwx9jaaC7VFK6CteKpAc/28HheS4I8yue/kKZI3GnhcuFN8U8rEh4Lrl5Bx/rTz00714TxMDym5+UWAVnhnu3NnxaxUqUU+sbDEERyH6VaHERYm5OrKbqEyEEuI1FrIWSFaMoPX0UEGZ8wook/zvg6xTgksIk5GaQk SG8da+wF OFE3Dc4rouAhv0Xgcgo4/WecvNcc6DDdSHTvFd0MX/0Y2yILX0CjuYBqJS/yx/2oaiJ+oIWxbb9O3GB7/aYijYw0hXhD1LsnEf9FJ+6Gb1iI53NU8Fa6eI+v3Jo7u24APLCWz8XoJbCrbTH7zbUt3CozCg/aOrp5/q3iJJ8BNl89+vJOwJpp9l1MV9FKmMgL7z9YCJfTUEnNIreYnammH/u9myuWgZQShOScLmz6GqZNUs78jfVOle3sTup6VuvYMlJEC6snRZbieUZKe4/LBQQrhUBJRRIqS9h3+1pzE5B/y1xdII+k6GvtdZHc8ce/m2F8Pd8IjfmZZ1OpQbFMUDZUFSz/0Dq5IM6eSEp/+LpP7yA5778PSE7hjIhibxggcXyZstmlv9B3U7RgEn5FxA1vDjnrGCW2QJKFwJj0fBKtHP4I4Fuet0/nXzb+f4Gvc0+ItVeEFnZJf0iueTSW46SrBW+IdWk/xY10xwsdPrz/MOkVUFhgMdvcy7SxoBXJUdv4s9dlrllvOPmxOzbCLf/s8HF+p9Jv6U1GIUsFR/xI2+P7O6+/rFFkcVsp39PKHUBsl3CJHw1gI1oU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.06.25 12:24, Muhammad Usama Anjum wrote: > Add test cases to test the correctness of PFN ZERO flag of pagemap_scan > ioctl. Test with normal pages backed memory and huge pages backed > memory. Just to verify: would this trigger on kernels before my fix? > > Cc: David Hildenbrand > Signed-off-by: Muhammad Usama Anjum > --- > The bug has been fixed [1]. > > [1] https://lore.kernel.org/all/20250617143532.2375383-1-david@redhat.com > --- > tools/testing/selftests/mm/pagemap_ioctl.c | 57 +++++++++++++++++++++- > 1 file changed, 56 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c > index 57b4bba2b45f3..6138de0087edf 100644 > --- a/tools/testing/selftests/mm/pagemap_ioctl.c > +++ b/tools/testing/selftests/mm/pagemap_ioctl.c > @@ -1,4 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > + > #define _GNU_SOURCE > #include > #include > @@ -1480,6 +1481,57 @@ static void transact_test(int page_size) > extra_thread_faults); > } > > +void zeropfn_tests(void) > +{ > + unsigned long long mem_size; > + struct page_region vec; > + int i, ret; > + char *mem; > + > + /* Test with page backed memory */ What is "page backed memory" ? :) > + mem_size = 10 * page_size; > + mem = mmap(NULL, mem_size, PROT_READ, MAP_PRIVATE | MAP_ANON, -1, 0); > + if (mem == MAP_FAILED) > + ksft_exit_fail_msg("error nomem\n"); > + > + /* Touch each page to ensure it's mapped */ > + for (i = 0; i < mem_size; i += page_size) > + (void)((volatile char *)mem)[i]; > + > + ret = pagemap_ioctl(mem, mem_size, &vec, 1, 0, > + (mem_size / page_size), PAGE_IS_PFNZERO, 0, 0, PAGE_IS_PFNZERO); > + if (ret < 0) > + ksft_exit_fail_msg("error %d %d %s\n", ret, errno, strerror(errno)); > + > + ksft_test_result(ret == 1 && LEN(vec) == (mem_size / page_size), > + "%s all pages must have PFNZERO set\n", __func__); > + > + munmap(mem, mem_size); > + > + /* Test with huge page */ > + mem_size = 10 * hpage_size; > + mem = memalign(hpage_size, mem_size); > + if (!mem) > + ksft_exit_fail_msg("error nomem\n"); > + > + ret = madvise(mem, mem_size, MADV_HUGEPAGE); > + if (ret) > + ksft_exit_fail_msg("madvise failed %d %s\n", errno, strerror(errno)); Might fail on older kernels, so we usually treat this as a skip. > + > + for (i = 0; i < mem_size; i += hpage_size) > + (void)((volatile char *)mem)[i]; > + > + ret = pagemap_ioctl(mem, mem_size, &vec, 1, 0, > + (mem_size / page_size), PAGE_IS_PFNZERO, 0, 0, PAGE_IS_PFNZERO); > + if (ret < 0) > + ksft_exit_fail_msg("error %d %d %s\n", ret, errno, strerror(errno)); > + > + ksft_test_result(ret == 1 && LEN(vec) == (mem_size / page_size), > + "%s all huge pages must have PFNZERO set\n", __func__); Wouldn't this be able to fail if /sys/kernel/mm/transparent_hugepage/use_zero_page is set to false, or if mmap() gave us a suboptimally-aligned range? You'd have to read each and every page to get the ordinary shared zeropage in these configs instead without making the test too complicated. > + > + free(mem); Shouldn't this be an munmap() ? > +} > + > int main(int __attribute__((unused)) argc, char *argv[]) > { > int shmid, buf_size, fd, i, ret; > @@ -1494,7 +1546,7 @@ int main(int __attribute__((unused)) argc, char *argv[]) > if (init_uffd()) > ksft_exit_pass(); > > - ksft_set_plan(115); > + ksft_set_plan(117); We should probably look into converting this test to kselftest_harness. -- Cheers, David / dhildenb