linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* RE: hugetlb page patch for 2.5.48-bug fixes
@ 2002-11-22  3:23 Seth, Rohit
  2002-11-24 14:44 ` Ed Tomlinson
  0 siblings, 1 reply; 10+ messages in thread
From: Seth, Rohit @ 2002-11-22  3:23 UTC (permalink / raw)
  To: 'William Lee Irwin III', Seth, Rohit
  Cc: linux-mm, linux-kernel, akpm, torvalds

> At some point in the past, I wrote:
> >> Okay, first off why are you using a list linked through 
> >> page->private?
> >> page->list is fully available for such tasks.
> 
> On Thu, Nov 21, 2002 at 05:54:22PM -0800, Seth, Rohit wrote:
> > Don't really need a list_head kind of thing for always inorder 
> > complete traversal. list_head (slightly) adds fat in data 
> structures 
> > as well as insertaion/removal. Please le me know if anything that 
> > prohibits the use of page_private field for internal use.
> 
> page->private is also available for internal use. The objection here
> was about not using the standardized list macros. I'm not 
> convinced about the fat since the keyspace is tightly bounded 
> and the back pointers are in struct page regardless. (And we 
> also just happen to know page->lru is also available though 
> I'd not suggest using it.)
> 

Either way. That is fine. I will make the change.

> 
> At some point in the past, I wrote:
> >> Third, the hugetlb_release_key() in unmap_hugepage_range() is
> >> the one that should be removed [along with its corresponding 
> >> mark_key_busy()], not the one in sys_free_hugepages(). 
> >> unmap_hugepage_range() is doing neither setup nor teardown of 
> >> the key itself, only the pages and PTE's. I would say 
> >> key-level refcounting belongs to sys_free_hugepages().
> 
> On Thu, Nov 21, 2002 at 05:54:22PM -0800, Seth, Rohit wrote:
> > It is not mandatory that user app calls free_pages.  Or 
> even in case 
> > of app aborts this call will not be made.  The internal 
> structures are 
> > always released during the exit (with last ref count) along 
> with free 
> > of underlying physical pages.
> 
> Hmm, I can understand caution wrt. touching core. I suspect 
> vma->close() should do hugetlb_key_release() instead of 
> sys_free_hugepages()?
> 
That is a good option for 2.5. I will update the patch tomorrow.

rohit
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2002-11-25  1:31 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-22  3:23 hugetlb page patch for 2.5.48-bug fixes Seth, Rohit
2002-11-24 14:44 ` Ed Tomlinson
2002-11-24 14:49   ` William Lee Irwin III
2002-11-24 15:01     ` Ed Tomlinson
2002-11-24 15:00       ` William Lee Irwin III
2002-11-24 15:21         ` opps in kswapd Ed Tomlinson
2002-11-24 15:30           ` William Lee Irwin III
2002-11-24 18:27             ` Ed Tomlinson
2002-11-25  1:28               ` Andrew Morton
2002-11-25  1:31                 ` Ed Tomlinson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox