From: William Lee Irwin III <wli@holomorphy.com>
To: Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>
Cc: Andrew Morton <akpm@digeo.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: get_user_pages rewrite (completed, updated for 2.4.46)
Date: Thu, 7 Nov 2002 03:38:42 -0800 [thread overview]
Message-ID: <20021107113842.GB23425@holomorphy.com> (raw)
In-Reply-To: <20021107110840.P659@nightmaster.csn.tu-chemnitz.de>
On Thu, Nov 07, 2002 at 11:08:40AM +0100, Ingo Oeser wrote:
+#ifdef OBSOLETE_PAGE_WALKER
+ if (vmas) {
+ gup_u.pv.vmas = vmas;
+ gup_u.pv.max_vmas = len;
+ walker = gup_add_pv;
+ printk("Obsolete argument \"vmas\" used!"
+ " Please send this report to linux-mm@vger.kernel.org"
+ " or fix the caller. Stack trace follows...\n");
+ WARN_ON(vmas);
+ }
+#else
+ /* FIXME: Or should we simply ignore it? -ioe */
+ BUG_ON(vmas);
+#endif
What on earth? Why not just remove the obsolete code?
Bill
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-11-07 11:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-07 10:08 Ingo Oeser
2002-11-07 11:38 ` William Lee Irwin III [this message]
[not found] ` <20021107135747.A594@rotuma.informatik.tu-chemnitz.de>
[not found] ` <20021107125955.GK19821@holomorphy.com>
2002-11-07 22:13 ` Ingo Oeser
2002-11-08 22:44 ` Andrew Morton
2002-11-09 17:52 ` [RFC PATCH] " Ingo Oeser
2002-11-09 22:41 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021107113842.GB23425@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@digeo.com \
--cc=ingo.oeser@informatik.tu-chemnitz.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox