linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: Andrew Morton <akpm@digeo.com>,
	linux-mm mailing list <linux-mm@kvack.org>
Subject: Re: Breakout struct page
Date: Mon, 7 Oct 2002 19:30:36 +0100	[thread overview]
Message-ID: <20021007193036.A25200@infradead.org> (raw)
In-Reply-To: <1165733025.1033777103@[10.10.2.3]>; from mbligh@aracnet.com on Sat, Oct 05, 2002 at 12:18:23AM -0700

On Sat, Oct 05, 2002 at 12:18:23AM -0700, Martin J. Bligh wrote:
> This very boring patch breaks out struct page into it's own header
> file. This should allow you to do struct page arithmetic in other
> header files using static inlines instead of horribly complex macros 
> ... by just including <linux/struct_page.h>, which avoids dependency
> problems.
> 
> (inlined to read, attatched for lower probability of mangling)

I don't like a struct_page.h in addition to page-flags.h.  I had a patch
for early 2.5 that create <linux/page.h> with struct page and stuff that
depends only on it (Test/Set/etc macros).  IHMO that's a nicer split,
but people may flame me for this..

I'm inclinde to resubmit that one after feature freeze.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

  parent reply	other threads:[~2002-10-07 18:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-05  7:18 Martin J. Bligh
2002-10-05  8:22 ` Andrew Morton
2002-10-07 18:30 ` Christoph Hellwig [this message]
2002-10-07 18:43   ` Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021007193036.A25200@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@digeo.com \
    --cc=linux-mm@kvack.org \
    --cc=mbligh@aracnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox