From: Andreas Dilger <adilger@clusterfs.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org,
"Martin J. Bligh" <Martin.Bligh@us.ibm.com>,
linux-mm@kvack.org
Subject: Re: [RFC][PATCH] 4KB stack + irq stack for x86
Date: Wed, 2 Oct 2002 15:56:49 -0600 [thread overview]
Message-ID: <20021002215649.GY3000@clusterfs.com> (raw)
In-Reply-To: <3D9B62AC.30607@us.ibm.com>
On Oct 02, 2002 14:18 -0700, Dave Hansen wrote:
> I've resynced Ben's patch against 2.5.40. However, I'm getting some
> strange failures. The patch is good enough to pass LTP, but
> consistently freezes when I run tcpdump on it.
>
> Although I don't have CONFIG_PREEMPT on, I have the feeling that I
> need to disable preemption in common_interrupt() like it was before.
> Any insights would be appreciated.
I'm a little bit worried about this patch. Have you tried something
like NFS-over-ext3-over-LVM-over-MD or so, which can have a deep stack?
We hit a bunch of deep stack problems like this (overflowing an 8kB stack)
even without interrupts involved when developing Lustre. Granted, we
fixed some large stack allocations in the ext3 indexed-directory code
and in our own code, but I'm still worried that a 4kB stack is too small.
The Stanford checker folks would probably be able to run a test for
large stack allocations in 2.5.40 if you asked them nicely, and maybe
even do stack depths for call chains.
Alternately, you could set up an 8kB stack + IRQ stack and "red-zone"
the high page of the current 8kB stack and see if it is ever used.
Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-10-02 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-02 21:18 Dave Hansen
2002-10-02 21:43 ` Benjamin LaHaise
2002-10-02 22:13 ` Dave Hansen
2002-10-02 21:56 ` Andreas Dilger [this message]
2002-10-02 22:02 ` Martin J. Bligh
2002-10-03 11:10 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021002215649.GY3000@clusterfs.com \
--to=adilger@clusterfs.com \
--cc=Martin.Bligh@us.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox