linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: linux-mm@kvack.org
Subject: [3/13] add __GFP_NOKILL to SLAB_KERNEL
Date: Wed, 25 Sep 2002 22:42:33 -0700	[thread overview]
Message-ID: <20020926054233.GJ22942@holomorphy.com> (raw)

Slab allocations are failable, hence any SLAB_KERNEL allocation should
be failed when not serviceable instead of killing innocent tasks. In
particular, vm_area_structs, temporary filename buffers (getname),
dentries, inodes, filp's, task_structs, and some others were all seen to
trigger the OOM killer. It seemed best to consolidate it in SLAB_KERNEL.


diff -urN linux-2.5.33/include/linux/slab.h linux-2.5.33-mm5/include/linux/slab.h
--- linux-2.5.33/include/linux/slab.h	2002-09-04 04:02:00.000000000 -0700
+++ linux-2.5.33-mm5/include/linux/slab.h	2002-09-08 20:55:27.000000000 -0700
@@ -20,10 +20,10 @@
 #define SLAB_NOHIGHIO		GFP_NOHIGHIO
 #define	SLAB_ATOMIC		GFP_ATOMIC
 #define	SLAB_USER		GFP_USER
-#define	SLAB_KERNEL		GFP_KERNEL
+#define	SLAB_KERNEL		(GFP_KERNEL | __GFP_NOKILL)
 #define	SLAB_DMA		GFP_DMA
 
-#define SLAB_LEVEL_MASK		(__GFP_WAIT|__GFP_HIGH|__GFP_IO|__GFP_HIGHIO|__GFP_FS)
+#define SLAB_LEVEL_MASK		(__GFP_WAIT|__GFP_HIGH|__GFP_IO|__GFP_HIGHIO|__GFP_FS|__GFP_NOKILL)
 #define	SLAB_NO_GROW		0x00001000UL	/* don't grow a cache */
 
 /* flags to pass to kmem_cache_create().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

                 reply	other threads:[~2002-09-26  5:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020926054233.GJ22942@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox