From: Ed Tomlinson <tomlins@cam.org>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] ageable slab callbacks
Date: Sun, 15 Sep 2002 19:54:25 -0400 [thread overview]
Message-ID: <200209151954.25689.tomlins@cam.org> (raw)
In-Reply-To: <3D851B5A.49F4296B@digeo.com>
On September 15, 2002 07:44 pm, Andrew Morton wrote:
> Hi, Ed.
Geez, I did miss alot didn't I? Thanks for the review, I will
eyeball the next one much more carefully.
> Ed Tomlinson wrote:
> > Hi,
> >
> > This lets the vm use callbacks to shrink ageable caches. With this we
> > avoid having to change vmscan if an ageable cache family is added. It
> > also batches calls to the prune methods (SHRINK_BATCH).
>
> I do believe it would be better to move the batching logic into
> slab.c and not make the individual cache implementations have
> to know about it. Just put the accumulators into cachep-> and
> only call the shrinker when the counter reaches the threshold
Yes it would be better. Problem is how to find the number of entries in
the cache we want to prune. We could ask the shrink callback return
this when passed a zero in ratio - I do not like dual purpose functions
that much though...
Thanks,
Ed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
prev parent reply other threads:[~2002-09-15 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-15 18:36 Ed Tomlinson
2002-09-15 23:44 ` Andrew Morton
2002-09-15 23:54 ` Ed Tomlinson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200209151954.25689.tomlins@cam.org \
--to=tomlins@cam.org \
--cc=akpm@digeo.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox