From: Ed Tomlinson <tomlins@cam.org>
To: Andrew Morton <akpm@digeo.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] slabasap-mm5_A2
Date: Mon, 9 Sep 2002 18:28:18 -0400 [thread overview]
Message-ID: <200209091828.18614.tomlins@cam.org> (raw)
In-Reply-To: <3D7D1B94.16F220E3@digeo.com>
On September 9, 2002 06:07 pm, Andrew Morton wrote:
> Ed Tomlinson wrote:
> > Hi Andrew,
> >
> > Found three oops when checking this afternoon's log. Looks like
> > *total_scanned can be zero...
> >
> > how about;
> >
> > ratio = pages > *total_scanned ? pages / (*total_scanned | 1) : 1;
>
> Yup, thanks. I went the "+ 1" route ;)
I used the above to catch two situations. One was if
to_reclaim = zone->pages_high - zone->free_pages;
if (to_reclaim < 0)
continue; /* zone has enough memory */
triggered an left *total_scanned zero, and second if to catch the case
when pages > *total_scanned. Think both might happen. In the oops,
think *total_scanned was zero.
Ed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
prev parent reply other threads:[~2002-09-09 22:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-07 14:06 [PATCH][RFC] slabnow Ed Tomlinson
2002-09-08 20:45 ` Daniel Phillips
2002-09-09 4:59 ` Andrew Morton
2002-09-09 5:14 ` Daniel Phillips
[not found] ` <200209081142.02839.tomlins@cam.org>
2002-09-08 20:56 ` [PATCH] slabasap-mm5_A2 Andrew Morton
2002-09-08 21:08 ` Andrew Morton
2002-09-08 21:14 ` Ed Tomlinson
2002-09-08 21:47 ` Andrew Morton
2002-09-08 21:48 ` Ed Tomlinson
2002-09-08 22:46 ` Andrew Morton
2002-09-09 9:29 ` Stephen C. Tweedie
2002-09-09 21:33 ` Ed Tomlinson
2002-09-09 22:07 ` Andrew Morton
2002-09-09 22:28 ` Ed Tomlinson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200209091828.18614.tomlins@cam.org \
--to=tomlins@cam.org \
--cc=akpm@digeo.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox