From: Christoph Hellwig <hch@infradead.org>
To: Mel <mel@csn.ul.ie>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: VM Regress 0.5 - Compile error with CONFIG_HIGHMEM
Date: Sat, 17 Aug 2002 13:21:53 +0100 [thread overview]
Message-ID: <20020817132153.A11758@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0208171206200.7887-100000@skynet>; from mel@csn.ul.ie on Sat, Aug 17, 2002 at 12:09:20PM +0100
On Sat, Aug 17, 2002 at 12:09:20PM +0100, Mel wrote:
> On Thu, 15 Aug 2002, Mel wrote:
>
> >
> > Project page: http://www.csn.ul.ie/~mel/projects/vmregress/
> > Download: http://www.csn.ul.ie/~mel/projects/vmregress/vmregress-0.5.tar.gz
>
> 0.5 won't compile with CONFIG_HIGHMEM set. Apply the following trivial
> patch and it will compile at least. VM Regress has not been tested with
> CONFIG_HIGHMEM set at all but there is no reason for it to fail because no
> presumptions has been made about the number of nodes or zones in the
> machine
>
>
> --- vmregress-0.5/src/sense/kvirtual.c Tue Aug 13 22:43:48 2002
> +++ vmregress-0.5-highmem/src/sense/kvirtual.c Sat Aug 17 12:03:02 2002
> @@ -29,6 +29,11 @@
> #include <linux/mm.h>
> #include <linux/sched.h>
>
> +#ifdef CONFIG_HIGHMEM
> +#include <linux/highmem.h>
> +#include <asm/highmem.h>
> +#endif
Shouldn't an undonditional #include <linux/highmem.h> do it much cleaner?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-08-17 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-15 2:15 VM Regress 0.5 Mel
2002-08-17 11:09 ` VM Regress 0.5 - Compile error with CONFIG_HIGHMEM Mel
2002-08-17 12:21 ` Christoph Hellwig [this message]
2002-08-18 0:01 ` Mel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020817132153.A11758@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox