linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Craig Kulesa <ckulesa@as.arizona.edu>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] (1/2) reverse mapping VM for 2.5.23 (rmap-13b)
Date: Wed, 19 Jun 2002 15:44:41 -0700	[thread overview]
Message-ID: <20020619224441.GP22961@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0206181340380.3031-100000@loke.as.arizona.edu>

On Wed, Jun 19, 2002 at 04:18:00AM -0700, Craig Kulesa wrote:
> Where:  http://loke.as.arizona.edu/~ckulesa/kernel/rmap-vm/
> This patch implements Rik van Riel's patches for a reverse mapping VM 
> atop the 2.5.23 kernel infrastructure.  The principal sticky bits in 

There is a small bit of trouble here: pte_chain_lock() needs to
preempt_disable() and pte_chain_unlock() needs to preempt_enable(),
as they are meant to protect critical sections.


Cheers,
Bill


On Wed, Jun 19, 2002 at 04:18:00AM -0700, Craig Kulesa wrote:
+static inline void pte_chain_lock(struct page *page)
+{
+   /*
+    * Assuming the lock is uncontended, this never enters
+    * the body of the outer loop. If it is contended, then
+    * within the inner loop a non-atomic test is used to
+    * busywait with less bus contention for a good time to
+    * attempt to acquire the lock bit.
+    */
+   while (test_and_set_bit(PG_chainlock, &page->flags)) {
+       while (test_bit(PG_chainlock, &page->flags))
+           cpu_relax();
+   }
+}
+
+static inline void pte_chain_unlock(struct page *page)
+{
+   clear_bit(PG_chainlock, &page->flags);
+}

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

  parent reply	other threads:[~2002-06-19 22:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-19 11:18 Craig Kulesa
2002-06-19 16:18 ` Andrew Morton
2002-06-19 17:00 ` Daniel Phillips
2002-06-19 17:11   ` Dave Jones
2002-06-19 17:35     ` Rik van Riel
2002-06-19 19:53       ` Ingo Molnar
2002-06-19 20:21         ` Craig Kulesa
2002-06-19 20:24           ` Linus Torvalds
2002-06-20 12:25             ` VM benchmarks for 2.5 (mainline & rmap patches) Craig Kulesa
2002-06-24 21:34             ` [PATCH] (1/2) reverse mapping VM for 2.5.23 (rmap-13b) Martin J. Bligh
2002-06-24 21:39               ` Rik van Riel
2002-06-24 21:56                 ` Martin J. Bligh
2002-07-04  5:19               ` Daniel Phillips
2002-06-24 15:02         ` Rik van Riel
2002-06-19 19:04 ` Steven Cole
2002-06-19 22:44 ` William Lee Irwin III [this message]
2002-06-20 12:08 ` [PATCH] Updated rmap VM for 2.5.23 (SMP, preempt fixes) Craig Kulesa
2002-06-20 12:45   ` Craig Kulesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020619224441.GP22961@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=ckulesa@as.arizona.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox