From: Ed Tomlinson <tomlins@cam.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC][PATCH] using page aging to shrink caches (pre8-ac5)
Date: Fri, 24 May 2002 08:14:25 -0400 [thread overview]
Message-ID: <200205240814.25293.tomlins@cam.org> (raw)
In-Reply-To: <20020524123535.A9618@infradead.org>
On May 24, 2002 07:35 am, Christoph Hellwig wrote:
> On Fri, May 24, 2002 at 07:28:45AM -0400, Ed Tomlinson wrote:
> > Comments, questions and feedback very welcome,
>
> Just from a short look:
>
> What about doing mark_page_accessed in kmem_touch_page?
mark_page_accessed expects a page struct. kmem_touch_page takes an
address in the page, converts it to a kernel address and then marks the page.
> And please do a s/pruner_t/kmem_pruner_t/
Yes. Done.
One other style question. I am not completely happy with kmem_shrink_slab.
Think that instead of setting the reference bit I should probably do something
like return:
-1 - cache is growing
0 - slab has inuse objects
n - pages were freed
Comments?
Ed Tomlinson
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-05-24 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-18 4:10 [RFC][PATCH] using page aging to shrink caches Ed Tomlinson
2002-05-21 18:47 ` Benjamin LaHaise
2002-05-24 11:28 ` [RFC][PATCH] using page aging to shrink caches (pre8-ac5) Ed Tomlinson
2002-05-24 11:35 ` Christoph Hellwig
2002-05-24 12:14 ` Ed Tomlinson [this message]
2002-05-24 12:20 ` Christoph Hellwig
2002-05-24 11:42 ` William Lee Irwin III
2002-05-29 12:01 ` Ed Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200205240814.25293.tomlins@cam.org \
--to=tomlins@cam.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox