From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@zip.com.au>
Cc: ekonijn@xs4all.nl, Dave Jones <davej@suse.de>,
Christoph Hellwig <hch@infradead.org>,
kernel-janitor-discuss@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: page-flags.h
Date: Wed, 15 May 2002 13:38:00 +0100 [thread overview]
Message-ID: <20020515133800.A25614@infradead.org> (raw)
In-Reply-To: <3CE172C7.C250E7E8@zip.com.au>; from akpm@zip.com.au on Tue, May 14, 2002 at 01:25:43PM -0700
On Tue, May 14, 2002 at 01:25:43PM -0700, Andrew Morton wrote:
> Erik van Konijnenburg wrote:
> >
> > ...
> > For pagemap.h, just three functions are responsible for
> > an 82Kb callgraph: page_cache_alloc, add_to_page_cache,
> > wait_on_page_locked.
>
> inlines in headers are just a pita. I know it gets people
> all excited but I'd say: make 'em macros.
>
> ___add_to_page_cache() can be just uninlined. I intend
> to gang-add pages into the cache and LRU anyway, so that
> function should become for "occasional use only" anyway.
I'm all for it. I nfact I have a patch to rename it to link_to_page_cache()
and make it an uninline FASTCALL pending, waiting for the buffer_head.h
patch going to Linus first.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-05-15 12:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020501192737.R29327@suse.de>
2002-05-01 17:34 ` page-flags.h Christoph Hellwig
2002-05-01 18:04 ` page-flags.h Dave Jones
2002-05-03 2:52 ` page-flags.h Andrew Morton
2002-05-03 8:24 ` page-flags.h Christoph Hellwig
2002-05-03 22:41 ` page-flags.h Erik van Konijnenburg
2002-05-03 23:06 ` page-flags.h Andrew Morton
2002-05-03 23:39 ` page-flags.h Dave Jones
2002-05-04 6:46 ` page-flags.h Erik van Konijnenburg
2002-05-14 20:25 ` page-flags.h Andrew Morton
2002-05-15 12:38 ` Christoph Hellwig [this message]
2002-08-29 19:04 ` page-flags.h Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020515133800.A25614@infradead.org \
--to=hch@infradead.org \
--cc=akpm@zip.com.au \
--cc=davej@suse.de \
--cc=ekonijn@xs4all.nl \
--cc=kernel-janitor-discuss@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox