From: "David S. Miller" <davem@redhat.com>
To: bcrl@redhat.com
Cc: andrea@suse.de, marcelo@conectiva.com.br, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] mmap bug with drivers that adjust vm_start
Date: Mon, 25 Mar 2002 20:00:31 -0800 (PST) [thread overview]
Message-ID: <20020325.200031.118818331.davem@redhat.com> (raw)
In-Reply-To: <20020325230046.A14421@redhat.com>
The patch below fixes a problem whereby a vma which has its vm_start
address changed by the file's mmap operation can result in the vma
being inserted into the wrong location within the vma tree. This
results in page faults not being handled correctly leading to SEGVs,
as well as various BUG()s hitting on exit of the mm. The fix is to
recalculate the insertion point when we know the address has changed.
Comments? Patch is against 2.4.19-pre4.
Good catch. Most of the time this happened to work because the driver
filled in the page tables completely (as is the case for most video
etc. drivers which use {io_,}remap_page_range et al..)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-03-26 4:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-26 4:00 Benjamin LaHaise
2002-03-26 4:00 ` David S. Miller [this message]
2002-03-26 16:42 ` Andrea Arcangeli
2002-03-26 18:57 ` Benjamin LaHaise
2002-03-26 19:15 ` Andrea Arcangeli
2002-03-26 20:43 ` Benjamin LaHaise
2002-03-26 21:18 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020325.200031.118818331.davem@redhat.com \
--to=davem@redhat.com \
--cc=andrea@suse.de \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox