From: William Lee Irwin III <wli@holomorphy.com>
To: Andrew Morton <akpm@zip.com.au>
Cc: Rik van Riel <riel@conectiva.com.br>,
"Marcelo W. Tosatti" <marcelo@conectiva.com.br>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] struct page shrinkage
Date: Mon, 25 Feb 2002 18:46:12 -0800 [thread overview]
Message-ID: <20020226024612.GO3511@holomorphy.com> (raw)
In-Reply-To: <3C7AF011.8B6ECCF0@zip.com.au>
Rik van Riel wrote:
>>
>> + clear_bit(PG_locked, &p->flags);
On Mon, Feb 25, 2002 at 06:16:49PM -0800, Andrew Morton wrote:
> Please don't do this. Please use the macros. If they're not
> there, please create them.
>
> Bypassing the abstractions in this manner confounds people
> who are implementing global locked-page accounting.
>
> In fact, I think I'll go rename all the page flags...
This is lingering context from the driver... it's ugly, I didn't
go after cleaning that up when I had to touch this function because
of the usual minimal-impact / only do one thing principle.
Perhaps others were similarly (un)motivated.
Cheers,
Bill
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-02-26 2:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-26 1:47 Rik van Riel
2002-02-26 1:49 ` David S. Miller
2002-02-26 1:57 ` Rik van Riel
2002-02-26 2:01 ` David S. Miller
2002-02-26 2:07 ` Rik van Riel
2002-02-26 2:54 ` William Lee Irwin III
2002-02-26 2:16 ` Andrew Morton
2002-02-26 2:46 ` William Lee Irwin III [this message]
2002-03-06 16:58 Bulent Abali
2002-03-06 17:33 ` Andrew Morton
2002-03-06 18:09 ` Rik van Riel
2002-03-06 18:41 Bulent Abali
2002-03-06 18:50 ` Mike Fedyk
2002-03-06 19:12 ` Andrew Morton
2002-03-06 19:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020226024612.GO3511@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcelo@conectiva.com.br \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox