From: "David S. Miller" <davem@redhat.com>
To: riel@conectiva.com.br
Cc: marcelo@conectiva.com.br, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] struct page shrinkage
Date: Mon, 25 Feb 2002 18:01:22 -0800 (PST) [thread overview]
Message-ID: <20020225.180122.120462472.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.33L.0202252254380.7820-100000@imladris.surriel.com>
On Mon, 25 Feb 2002, David S. Miller wrote:
> Please fix the atomic_t assumptions in init_page_count() first.
> You should be using atomic_set(...).
Why ? You'll see init_page_count() is _only_ used from
free_area_init_core(), when nothing else is using the VM
yet.
Rik, not every architecture has a "counter" member of
atomic_t, that is the problem. This is a hard bug, please
fix it. It is an opaque type, accessing its' implementation
directly is therefore illegal in the strongest way possible.
This exact same code has been in -rmap for a few months
and went into 2.5 just over a week ago. It doesn't seem
to give any problems ...
Because I haven't pushed my sparc64 changesets yet, I'm doing
that tonight.
Franks a lot,
David S. Miller
davem@redhat.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-02-26 2:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-26 1:47 Rik van Riel
2002-02-26 1:49 ` David S. Miller
2002-02-26 1:57 ` Rik van Riel
2002-02-26 2:01 ` David S. Miller [this message]
2002-02-26 2:07 ` Rik van Riel
2002-02-26 2:54 ` William Lee Irwin III
2002-02-26 2:16 ` Andrew Morton
2002-02-26 2:46 ` William Lee Irwin III
2002-03-06 16:58 Bulent Abali
2002-03-06 17:33 ` Andrew Morton
2002-03-06 18:09 ` Rik van Riel
2002-03-06 18:41 Bulent Abali
2002-03-06 18:50 ` Mike Fedyk
2002-03-06 19:12 ` Andrew Morton
2002-03-06 19:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020225.180122.120462472.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcelo@conectiva.com.br \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox